The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6e01219fe39b6a93d69410b0d44646222d733f95

commit 6e01219fe39b6a93d69410b0d44646222d733f95
Author: Xixuan Wu <xixuan@chromium.org>
Date: Mon Aug 20 04:17:31 2018

autotest: Use dependencies in control file as bot dimensions.

BUG=chromium:873886
TEST=Test on cros-skylab-staging-2.hot.

Change-Id: I50aac9fdeaa5921aa300e340c3082bbae98f831c
Reviewed-on: https://chromium-review.googlesource.com/1180734
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
Commit-Queue: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/6e01219fe39b6a93d69410b0d44646222d733f95/venv/skylab_suite/suite_runner.py

After I pass in dependencies as 'label-tag' in dimension, there're some tests cannot be passed, like: 

https://chrome-swarming.appspot.com/task?id=3f6f76d76ce21610&refresh=10

because it needs "label-tag: cleanup-reboot", but no DUT has it.

It's a CQ test.

Re #4: There are four "dependencies" in control files that are really hints that autotest scheduler acts on (are not actual dimensions / labels).

See  issue 753464  for gory details.

My recommendation for skylab:

- skip_provision -- do not support. (i.e. skylab_suite should filter this out and warn when creating a test.
- cleanup-reboot -- do not support. (i.e. skylab_suite should filter this out and warn when creating a test.
- rpm -- Does not work. Drop.
- modem_repair -- punt. I was partially responsible back in the day for adding this, and know for a fact that noone is watching this today.

Also, as https://bugs.chromium.org/p/chromium/issues/detail?id=753464#c4 states, if have to add these features back into Skylab, the right way is to have the test control file be parsed by autoserv / lucifer and have them act on the options -- these are modifiers to test execution, not test scheduling. So Skylab suite / swarming should not know / care about them.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/79d1466fcd46b78c68c949c98696bedec610457d

commit 79d1466fcd46b78c68c949c98696bedec610457d
Author: Xixuan Wu <xixuan@chromium.org>
Date: Mon Aug 20 18:26:14 2018

autotest: Skip some not-supported dependencies in skylab.

BUG=chromium:873886
TEST=None

Change-Id: I7ac8189bef681e88753b8d6fca2f296b72bc1545
Reviewed-on: https://chromium-review.googlesource.com/1181762
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
Commit-Queue: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/79d1466fcd46b78c68c949c98696bedec610457d/venv/skylab_suite/suite_runner.py

I don't understand what you're trying to do in https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1180734

[1] Why is the dimension being added called 'label-tag'?
[2] You're overwriting that dimension as you go through the dependency list.

For example if a dependency is ec:cros,
you will add label-tag:ec:cros, whereas you should be adding label-ec:cros

(Actually you should be adding label-ec:EC_TYPE_CHROME_OS but we'll get there later.

Something like: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1187886

(I'll polish it up tomorrow)

Re #8, it's just a temporarily fix for letting such tests NO_RESOURCE first. At that time, the tags haven't been supported in skylab.

After your work of fully supporting autotest tags in skylab, this part will be changed.