New issue
Advanced search Search tips

Issue 873881 link

Starred by 1 user
Status: Fixed
Owner:
cduvall@chromium.org
Closed: Aug 17
Cc:
cduvall@chromium.org
lanwei@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

4.5%-662.5% regression in rendering.mobile at 582123:582213

Project Member Reported by lanwei@chromium.org, Aug 14 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 14 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=873881

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=c2c9d6f9727537a4a743101be1e741a416ee108473e1cb359a6a447b6dbea943


Bot(s) for this bug's original alert(s):

Android Nexus6 WebView Perf
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 14

Cc: cduvall@chromium.org
Owner: cduvall@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12e16898640000

Enable subresource redirects to all schemes with network service by cduvall@chromium.org
https://chromium.googlesource.com/chromium/src/+/b2680c227c2594e12eaab1962fc9d9e350616a19
15.34 → 106.3 (+91)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Aug 15 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/11f90d4a640000

Revert "Enable subresource redirects to all schemes with network service" by cduvall@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/1176483/2
85.98 → 15.48 (-70.5)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Aug 16 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14f0a8da640000

Revert "Enable subresource redirects to all schemes with network service" by cduvall@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/1176483/3
102.9 → 9.736 (-93.13)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Aug 16 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/11758cd2640000
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Aug 16 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14951256640000

Revert "Enable subresource redirects to all schemes with network service" by cduvall@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/1176483/5
101.5 → 13.28 (-88.27)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 13 by 42576172...@developer.gserviceaccount.com, Aug 16 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/128ecdec640000

Fix perf regression from ThrottlingURLLoader changes by cduvall@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/1178576/1
98.31 → 15.61 (-82.7)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 15 by 42576172...@developer.gserviceaccount.com, Aug 16 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/16c0e746640000

Fix perf regression from ThrottlingURLLoader changes by cduvall@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/1178576/3
95.7 → 11.84 (-83.86)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46fc006bf8bf8a19730b72b57f4868ad31724da7

commit 46fc006bf8bf8a19730b72b57f4868ad31724da7
Author: Clark DuVall <cduvall@chromium.org>
Date: Fri Aug 17 15:49:32 2018

Fix perf regression from ThrottlingURLLoader changes

It looks like some of the changes to ThrottlingURLLoader in
http://crrev.com/c/1157549 caused some perf regressions on mobile. This
fixes the regressions. Something with how StartInfo was created and
passed around before was causing problems.

See bugs for more info. Confirmed regressions fixed with this CL using
pinpoint.

Bug: 874902,  873881 ,  874918 
Change-Id: I34397b8f97cffa82857f87ed19ac6ef5b61a7cac
Reviewed-on: https://chromium-review.googlesource.com/1178576
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584086}
[modify] https://crrev.com/46fc006bf8bf8a19730b72b57f4868ad31724da7/content/common/throttling_url_loader.cc
[modify] https://crrev.com/46fc006bf8bf8a19730b72b57f4868ad31724da7/content/common/throttling_url_loader.h

Comment 17 by cduvall@chromium.org, Aug 17

Status: Fixed (was: Assigned)
►

Sign in to add a comment