chrome/browser/extensions should not depend on or include sources from chrome/browser/apps/platform_apps, but currently does. We should break that, and enforce that no dependency or includes are allowed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f587b41f9c0bad93ab16c0f3c5a9b67ca4cd8e11 commit f587b41f9c0bad93ab16c0f3c5a9b67ca4cd8e11 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue Aug 14 01:35:09 2018 [Extensions + Apps] Restrict extensions includes of apps code Add restrictions so that code from chrome/browser/extensions is not allowed to include files in chrome/browser/apps. Carve out exceptions for existing includes, which should gradually be cleaned up. Bug: 873872 Change-Id: I50c3338945456ec5b9deba02865cc8d38cf93462 Reviewed-on: https://chromium-review.googlesource.com/1172155 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#582788} [modify] https://crrev.com/f587b41f9c0bad93ab16c0f3c5a9b67ca4cd8e11/chrome/browser/extensions/DEPS [modify] https://crrev.com/f587b41f9c0bad93ab16c0f3c5a9b67ca4cd8e11/chrome/browser/extensions/api/DEPS [modify] https://crrev.com/f587b41f9c0bad93ab16c0f3c5a9b67ca4cd8e11/chrome/browser/extensions/api/developer_private/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5c5a0c74b806f8b93a1588643895c211caa5847 commit c5c5a0c74b806f8b93a1588643895c211caa5847 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Aug 15 04:04:10 2018 [Extensions + Apps] Move application termination observation to apps Currently, the ExtensionsSystem watches for application termination, and then forwards the notification along to the apps code. This causes a dependency between the extensions system and apps. Move the application termination observation to a dedicated KeyedService in platform_apps code, and remove knowledge of platform apps from the extensions system. Bug: 873872 Change-Id: I2dc6ae147acc4bad428542f5c5ed31154355304b Reviewed-on: https://chromium-review.googlesource.com/1173765 Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#583158} [modify] https://crrev.com/c5c5a0c74b806f8b93a1588643895c211caa5847/chrome/browser/apps/platform_apps/BUILD.gn [add] https://crrev.com/c5c5a0c74b806f8b93a1588643895c211caa5847/chrome/browser/apps/platform_apps/app_termination_observer.cc [add] https://crrev.com/c5c5a0c74b806f8b93a1588643895c211caa5847/chrome/browser/apps/platform_apps/app_termination_observer.h [modify] https://crrev.com/c5c5a0c74b806f8b93a1588643895c211caa5847/chrome/browser/apps/platform_apps/browser_context_keyed_service_factories.cc [modify] https://crrev.com/c5c5a0c74b806f8b93a1588643895c211caa5847/chrome/browser/apps/platform_apps/browser_context_keyed_service_factories.h [modify] https://crrev.com/c5c5a0c74b806f8b93a1588643895c211caa5847/chrome/browser/extensions/DEPS [modify] https://crrev.com/c5c5a0c74b806f8b93a1588643895c211caa5847/chrome/browser/extensions/extension_system_impl.cc [modify] https://crrev.com/c5c5a0c74b806f8b93a1588643895c211caa5847/chrome/browser/extensions/extension_system_impl.h
Comment 1 by bugdroid1@chromium.org
, Aug 14