New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 873866 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ukm SourceId should have an opaque type

Project Member Reported by holte@chromium.org, Aug 13 
To avoid issues like crbug/870407, we should have an opaque type for ukm SourceIds that can't be implicitly converted to a smaller type.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3880edde90c9500b431cf472cf0ee70d86eb3944

commit 3880edde90c9500b431cf472cf0ee70d86eb3944
Author: Steven Holte <holte@google.com>
Date: Fri Aug 17 00:15:40 2018

Create an opaque type for UKM SourceIds.

Bug: 873866
Change-Id: I260aaf9bb1b7162e651d09595231b565d56c1958
Reviewed-on: https://chromium-review.googlesource.com/1173022
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583897}
[modify] https://crrev.com/3880edde90c9500b431cf472cf0ee70d86eb3944/base/BUILD.gn
[add] https://crrev.com/3880edde90c9500b431cf472cf0ee70d86eb3944/base/metrics/ukm_source_id.cc
[add] https://crrev.com/3880edde90c9500b431cf472cf0ee70d86eb3944/base/metrics/ukm_source_id.h
[modify] https://crrev.com/3880edde90c9500b431cf472cf0ee70d86eb3944/components/ukm/test_ukm_recorder.h
[modify] https://crrev.com/3880edde90c9500b431cf472cf0ee70d86eb3944/components/ukm/ukm_recorder_impl.h
[modify] https://crrev.com/3880edde90c9500b431cf472cf0ee70d86eb3944/services/metrics/public/cpp/ukm_entry_builder_base.cc
[modify] https://crrev.com/3880edde90c9500b431cf472cf0ee70d86eb3944/services/metrics/public/cpp/ukm_entry_builder_base.h
[modify] https://crrev.com/3880edde90c9500b431cf472cf0ee70d86eb3944/services/metrics/public/cpp/ukm_recorder.cc
[modify] https://crrev.com/3880edde90c9500b431cf472cf0ee70d86eb3944/services/metrics/public/cpp/ukm_recorder.h
[modify] https://crrev.com/3880edde90c9500b431cf472cf0ee70d86eb3944/services/metrics/public/cpp/ukm_source_id.cc
[modify] https://crrev.com/3880edde90c9500b431cf472cf0ee70d86eb3944/services/metrics/public/cpp/ukm_source_id.h
[modify] https://crrev.com/3880edde90c9500b431cf472cf0ee70d86eb3944/tools/metrics/ukm/builders_template.py
►

Sign in to add a comment