DevTools opened against cnn.com allocates at 20MB/sec rate and eventually OOMs. |
|||||||||
Issue descriptionPlease find the sampling heap profile attached. You can open it with DT memory panel.
,
Aug 21
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/e987606a8a187d62e24bd16d7fbda9e786d6a247 commit e987606a8a187d62e24bd16d7fbda9e786d6a247 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Tue Aug 21 19:03:49 2018 inspector: do not convert and store String16 for script source We need script source for: - calculating hash to report as part of scriptParsed event, - reporting it as response on getScriptSource request, - searching inside as response on searchInContent request, - breakpoints hints. In all cases there is no need to store source on inspector side. R=alph@chromium.org Bug: chromium:873865,v8:7731 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ice24ddc72cfff36fb9a2dff2d7c4543defe3f668 Reviewed-on: https://chromium-review.googlesource.com/1182603 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#55286} [modify] https://crrev.com/e987606a8a187d62e24bd16d7fbda9e786d6a247/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/e987606a8a187d62e24bd16d7fbda9e786d6a247/src/inspector/v8-debugger-script.cc [modify] https://crrev.com/e987606a8a187d62e24bd16d7fbda9e786d6a247/src/inspector/v8-debugger-script.h
,
Aug 21
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/6b860b6977186dea0e81c7f57fda615f8a7be61d commit 6b860b6977186dea0e81c7f57fda615f8a7be61d Author: Maya Lekova <mslekova@chromium.org> Date: Wed Aug 22 09:30:03 2018 Revert "inspector: do not convert and store String16 for script source" This reverts commit e987606a8a187d62e24bd16d7fbda9e786d6a247. Reason for revert: Speculatively reverting due to possible failure: https://ci.chromium.org/p/v8/builders/luci.v8.ci/Android%20Builder/8641 Original change's description: > inspector: do not convert and store String16 for script source > > We need script source for: > - calculating hash to report as part of scriptParsed event, > - reporting it as response on getScriptSource request, > - searching inside as response on searchInContent request, > - breakpoints hints. > > In all cases there is no need to store source on inspector side. > > R=alph@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Ice24ddc72cfff36fb9a2dff2d7c4543defe3f668 > Reviewed-on: https://chromium-review.googlesource.com/1182603 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55286} TBR=alph@chromium.org,kozyatinskiy@chromium.org Change-Id: I38d744dc811a5b747c1fcf27d88bdf770acf5c18 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:873865, v8:7731 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1184742 Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#55290} [modify] https://crrev.com/6b860b6977186dea0e81c7f57fda615f8a7be61d/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/6b860b6977186dea0e81c7f57fda615f8a7be61d/src/inspector/v8-debugger-script.cc [modify] https://crrev.com/6b860b6977186dea0e81c7f57fda615f8a7be61d/src/inspector/v8-debugger-script.h
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a54b18467dd73f81cbc144b3a35335bf39b6c6c commit 4a54b18467dd73f81cbc144b3a35335bf39b6c6c Author: Maya Lekova <mslekova@chromium.org> Date: Wed Aug 22 11:13:16 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: Speculatively reverting because of https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064%20(dbg)/13264 Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org Change-Id: I60ab243107d5fcce100064232d0e278a51f38db9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:873865, v8:7731 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1184921 Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#55300} [modify] https://crrev.com/4a54b18467dd73f81cbc144b3a35335bf39b6c6c/src/debug/debug.cc [modify] https://crrev.com/4a54b18467dd73f81cbc144b3a35335bf39b6c6c/src/debug/debug.h [modify] https://crrev.com/4a54b18467dd73f81cbc144b3a35335bf39b6c6c/src/inspector/search-util.cc [modify] https://crrev.com/4a54b18467dd73f81cbc144b3a35335bf39b6c6c/src/inspector/search-util.h [modify] https://crrev.com/4a54b18467dd73f81cbc144b3a35335bf39b6c6c/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a54b18467dd73f81cbc144b3a35335bf39b6c6c/src/json-parser.cc [modify] https://crrev.com/4a54b18467dd73f81cbc144b3a35335bf39b6c6c/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a54b18467dd73f81cbc144b3a35335bf39b6c6c/test/inspector/debugger/script-on-after-compile.js
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/cd7f9c63be2f42ea4d59fafdbfa59811daf71252 commit cd7f9c63be2f42ea4d59fafdbfa59811daf71252 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Wed Aug 29 19:48:01 2018 Reland "inspector: find magic comment using V8 scanner" This is a reland of 1b3b808a5452cb53512b3e76505533c61e020b98 Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org Bug: chromium:873865, v8:7731 Change-Id: I097678fda0ebdcbd35a85be0bb6cf0fcb052bcbd Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1195533 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#55507} [modify] https://crrev.com/cd7f9c63be2f42ea4d59fafdbfa59811daf71252/src/debug/debug.cc [modify] https://crrev.com/cd7f9c63be2f42ea4d59fafdbfa59811daf71252/src/debug/debug.h [modify] https://crrev.com/cd7f9c63be2f42ea4d59fafdbfa59811daf71252/src/inspector/search-util.cc [modify] https://crrev.com/cd7f9c63be2f42ea4d59fafdbfa59811daf71252/src/inspector/search-util.h [modify] https://crrev.com/cd7f9c63be2f42ea4d59fafdbfa59811daf71252/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/cd7f9c63be2f42ea4d59fafdbfa59811daf71252/src/json-parser.cc [modify] https://crrev.com/cd7f9c63be2f42ea4d59fafdbfa59811daf71252/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/cd7f9c63be2f42ea4d59fafdbfa59811daf71252/test/inspector/debugger/script-on-after-compile.js
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/3ca15cdda70038d07437333235852f51c891ad4f commit 3ca15cdda70038d07437333235852f51c891ad4f Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Wed Aug 29 23:43:30 2018 Reland "inspector: do not convert and store String16 for script source" This is a reland of e987606a8a187d62e24bd16d7fbda9e786d6a247 Original change's description: > inspector: do not convert and store String16 for script source > > We need script source for: > - calculating hash to report as part of scriptParsed event, > - reporting it as response on getScriptSource request, > - searching inside as response on searchInContent request, > - breakpoints hints. > > In all cases there is no need to store source on inspector side. > > R=alph@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Ice24ddc72cfff36fb9a2dff2d7c4543defe3f668 > Reviewed-on: https://chromium-review.googlesource.com/1182603 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55286} TBR=alph@chromium.org Bug: chromium:873865, v8:7731 Change-Id: I0a0e93cd9d7797e4b3c57b1ab4f1a20af27fea9c Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1195907 Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#55509} [modify] https://crrev.com/3ca15cdda70038d07437333235852f51c891ad4f/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/3ca15cdda70038d07437333235852f51c891ad4f/src/inspector/v8-debugger-script.cc [modify] https://crrev.com/3ca15cdda70038d07437333235852f51c891ad4f/src/inspector/v8-debugger-script.h
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4a96850aeb8e8b670a58c76d2cba11a36bd67c74 commit 4a96850aeb8e8b670a58c76d2cba11a36bd67c74 Author: Yang Guo <yangguo@chromium.org> Date: Mon Sep 03 18:42:28 2018 Revert "inspector: find magic comment using V8 scanner" This reverts commit 1b3b808a5452cb53512b3e76505533c61e020b98. Reason for revert: crbug/879988 TBR=kozy@chromium.org Original change's description: > inspector: find magic comment using V8 scanner > > Inspector tries to provide sourceURL and sourceMappingURL for scripts > with parser errors. Without this CL we convert source of each script > to inspector string and search for magic comment there. Some web sites > use pattern when they get some data from network and constantly try to > parse this data as JSON, in this case we do a lot of useless work. > > So we can parse magic comments on V8 side only for compilation errors > (excluding parse JSON errors), to do it we can reuse scanner by running > it on each potential comment. > > R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 > Reviewed-on: https://chromium-review.googlesource.com/1182446 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55280} TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:873865, v8:7731, chromium:879988 Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1202583 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55594} [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/debug/debug.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/search-util.h [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/src/json-parser.cc [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/4a96850aeb8e8b670a58c76d2cba11a36bd67c74/test/inspector/debugger/script-on-after-compile.js
,
Oct 17
Does not seem to be fixed. I can still see the growth. Was it reverted?
,
Oct 17
Issue 856815 has been merged into this issue.
,
Oct 17
Original issue with script source was fixed. Root of current issue is reporting full async chain inside scriptParsed event. I have fix under review: https://chromium-review.googlesource.com/c/v8/v8/+/1286959
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/b2b7e8deb427e23c95ab255e05abcd11c841280a commit b2b7e8deb427e23c95ab255e05abcd11c841280a Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu Oct 18 16:16:57 2018 inspector: do not report async tail in Debugger.scriptParsed event Async tail might be long. On frontend side we use only top frame so we can report tail using id. R=dgozman@chromium.org Bug: chromium:873865 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie9e6b5c4c000cc6bedce2d5fec9f3fa22ea21768 Reviewed-on: https://chromium-review.googlesource.com/c/1286959 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#56784} [modify] https://crrev.com/b2b7e8deb427e23c95ab255e05abcd11c841280a/src/inspector/v8-debugger-agent-impl.cc [modify] https://crrev.com/b2b7e8deb427e23c95ab255e05abcd11c841280a/src/inspector/v8-stack-trace-impl.cc [modify] https://crrev.com/b2b7e8deb427e23c95ab255e05abcd11c841280a/src/inspector/v8-stack-trace-impl.h [add] https://crrev.com/b2b7e8deb427e23c95ab255e05abcd11c841280a/test/inspector/debugger/script-origin-stack-expected.txt [add] https://crrev.com/b2b7e8deb427e23c95ab255e05abcd11c841280a/test/inspector/debugger/script-origin-stack.js [modify] https://crrev.com/b2b7e8deb427e23c95ab255e05abcd11c841280a/test/inspector/protocol-test.js
,
Dec 5
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Aug 21