Issue metadata
Sign in to add a comment
|
[Cleanup] Split refresh tab path calculations from pre-refresh ones |
||||||||||||||||||||||||
Issue descriptionSee this comment for an explanation: https://chromium-review.googlesource.com/c/chromium/src/+/1171917#message-df97eb4e6264bb6a2a2bf77a6512aff55dd3397a
,
Aug 14
I really don't think these are dupes. The other issue is about changing the implementation. This is about changing the API. I mean, I guess you could implement both at once, but they're specifying distinct things, and I'd rather not lose the information on this bug. Keeping open for now.
,
Aug 15
I literally had an implementation that did this (and did both) but got wiped out by merge conflicts. I was planning on bringing it back after the rendering for M69 stabilized.
,
Aug 22
,
Aug 23
,
Sep 11
We've shipped Refresh and the major functional work in the tabstrip is done. I was considering going through a lot of frame and tabstrip code and ripping out pre-Refresh stuff. Was your team already in process of that, and how do you want to coordinate it against the work you're doing here, which could otherwise proceed now?
,
Sep 17
,
Sep 17
,
Sep 17
Work will be limited to cleanup of pre-refresh code. Additional cleanup will happen ala issue 864836 , etc.
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65181316897fd37d04cfcb07245159597556f39a commit 65181316897fd37d04cfcb07245159597556f39a Author: Peter Kasting <pkasting@chromium.org> Date: Wed Sep 19 19:54:28 2018 Cleanup pre-refresh functionality in tab.cc, part 1. This removes support for pre-refresh modes. It does not change the design of path computations/drawing or other deeper refactors. Also does some other minor cleanup, and fixes one clear bug with high DPI in PaintChildren(). Bug: 873855 Change-Id: I3496ea60ed670d5f1c30abf33b989162c558fa16 Reviewed-on: https://chromium-review.googlesource.com/1231898 Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#592527} [modify] https://crrev.com/65181316897fd37d04cfcb07245159597556f39a/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc [modify] https://crrev.com/65181316897fd37d04cfcb07245159597556f39a/chrome/browser/ui/views/tabs/tab.cc [modify] https://crrev.com/65181316897fd37d04cfcb07245159597556f39a/chrome/browser/ui/views/tabs/tab.h [modify] https://crrev.com/65181316897fd37d04cfcb07245159597556f39a/chrome/browser/ui/views/tabs/tab_close_button.h [modify] https://crrev.com/65181316897fd37d04cfcb07245159597556f39a/chrome/browser/ui/views/tabs/tab_controller.h [modify] https://crrev.com/65181316897fd37d04cfcb07245159597556f39a/chrome/browser/ui/views/tabs/tab_strip_unittest.cc [modify] https://crrev.com/65181316897fd37d04cfcb07245159597556f39a/chrome/browser/ui/views/tabs/tab_unittest.cc
,
Oct 8
,
Oct 9
Hi, sorry not sure what this bug is about, the explanation doesn't say enough for me to follow what it means in the code. Are you hoping to delete the !IsRefreshUi() paths? What would you like me to do with this bug?
,
Oct 9
I think this was supposed to be assigned to a different Dana
,
Oct 9
,
Oct 17
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dfried@chromium.org
, Aug 14Owner: dfried@chromium.org
Status: Duplicate (was: Assigned)