net_unittests failures on chromeos VM with dchecks on |
||||||
Issue descriptionFYI Bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-amd64-generic-rel-vm-tests?limit=200 Sample failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-amd64-generic-rel-vm-tests/4635 Failing tests: TCPSocketTest.SPWNoAdvance URLRequestTestHTTP.TestPostChunkedDataAfterStart UDPSocketTest.LocalBroadcast Stacks: [ RUN ] TCPSocketTest.SPWNoAdvance ../../net/socket/tcp_socket_unittest.cc:209: Failure Expected equality of these values: expect_rtt_notification_count Which is: 3 watcher_ptr->rtt_notification_count() Which is: 0 Stack trace: #0 0x565eae796dfc testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x565eae796746 testing::internal::AssertHelper::operator=() #2 0x565eadca440c net::(anonymous namespace)::TCPSocketTest::TestSPWNotifications() [ FAILED ] TCPSocketTest.SPWNoAdvance (49 ms) [ RUN ] URLRequestTestHTTP.TestPostChunkedDataAfterStart [6874:6874:0813/143304.619730:193501584:FATAL:run_loop.cc(214)] Check failed: IsRunningOnCurrentThread(). #0 0x599ae6fe840c base::debug::StackTrace::StackTrace() #1 0x599ae6f8714b logging::LogMessage::~LogMessage() #2 0x599ae6fa6f4e base::RunLoop::QuitCurrentWhenIdleDeprecated() #3 0x599ae6f5fd1e net::TestDelegate::OnResponseCompleted() #4 0x599ae6f5fc33 net::TestDelegate::OnReadCompleted() #5 0x599ae6f5f8c3 net::TestDelegate::OnResponseStarted() #6 0x599ae6e94df2 net::URLRequest::NotifyResponseStarted() #7 0x599ae6ea48fc net::URLRequestJob::NotifyHeadersComplete() #8 0x599ae6e9d5f1 net::URLRequestHttpJob::NotifyHeadersComplete() #9 0x599ae6ea0110 net::URLRequestHttpJob::SaveCookiesAndNotifyHeadersComplete() #10 0x599ae6e9f339 net::URLRequestHttpJob::OnStartCompleted() #11 0x599ae6cb9aa1 net::HttpCache::Transaction::DoLoop() #12 0x599ae5cec45c _ZN4base8internal7InvokerINS0_9BindStateIMN3net4test18UDPSocketPosixTestEFviEJNS_7WeakPtrIS5_EEEEEFviEE3RunEPNS0_13BindStateBaseEi #13 0x599ae6cd76db net::HttpNetworkTransaction::DoCallback() #14 0x599ae6d023ab net::HttpStreamParser::OnIOComplete() #15 0x599ae5cec45c _ZN4base8internal7InvokerINS0_9BindStateIMN3net4test18UDPSocketPosixTestEFviEJNS_7WeakPtrIS5_EEEEEFviEE3RunEPNS0_13BindStateBaseEi #16 0x599ae6c0aa3c net::UploadDataStream::OnReadCompleted() #17 0x599ae6bf123f net::ChunkedUploadDataStream::AppendData() #18 0x599ae6bf0f17 net::ChunkedUploadDataStream::Writer::AppendData() #19 0x599ae5c628a9 net::URLRequestTestHTTP_TestPostChunkedDataAfterStart_Test::TestBody() #20 0x599ae6166c82 testing::Test::Run() #21 0x599ae6167890 testing::TestInfo::Run() #22 0x599ae6167dc7 testing::TestCase::Run() #23 0x599ae6173f67 testing::internal::UnitTestImpl::RunAllTests() #24 0x599ae6173acb testing::UnitTest::Run() #25 0x599ae72a4c7e base::TestSuite::Run() #26 0x599ae72a760f base::(anonymous namespace)::LaunchUnitTestsInternal() #27 0x599ae72a745e base::LaunchUnitTests() #28 0x599ae5873244 main #29 0x78e07670b736 __libc_start_main #30 0x599ae44b8c09 _start UDPSocketTest.LocalBroadcast fails silently
,
Aug 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f920f8263283dd1b90446b1f61d8f14d3ea3735 commit 7f920f8263283dd1b90446b1f61d8f14d3ea3735 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Tue Aug 14 18:56:21 2018 Disable failing net_unittests on ChromeOS. With DCHECKs on, these tests fail on ChromeOS. Bug: 873851 Test: These are the tests. Change-Id: I0f823918462dfb66c5fa8307e7d76150d8dacd6f Reviewed-on: https://chromium-review.googlesource.com/1173506 Reviewed-by: Asanka Herath <asanka@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#582987} [modify] https://crrev.com/7f920f8263283dd1b90446b1f61d8f14d3ea3735/net/socket/tcp_socket_unittest.cc [modify] https://crrev.com/7f920f8263283dd1b90446b1f61d8f14d3ea3735/net/socket/udp_socket_unittest.cc [modify] https://crrev.com/7f920f8263283dd1b90446b1f61d8f14d3ea3735/net/url_request/url_request_unittest.cc
,
Aug 14
I'm going to break the failures into separate issues. They have different root causes.
,
Aug 14
I haven't had great success in reproducing these failures locally (maybe Ben can help), but in theory this should work: https://chromium.googlesource.com/chromiumos/docs/+/master/cros_vm.md#run-a-chrome-gtest-binary-in-the-vm
,
Aug 14
,
Aug 14
Cool. Thanks for the pointer.
,
Aug 14
Filed bug 852590 a bit ago for UDPSocketTest.LocalBroadcast. Didn't get very far... so thnx for disabling it.
,
Aug 14
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f05753ec9837b06105a621271ab2a124d37c0ac6 commit f05753ec9837b06105a621271ab2a124d37c0ac6 Author: Asanka Herath <asanka@chromium.org> Date: Thu Aug 16 17:38:20 2018 [net] Fix URLRequestTestHTTP.TestPostChunkedDataAfterStart The test was calling TestDelegate.RunUntilComplete() after writing some data to a ChunkedUploadDataStream::Writer. However, the final write may itself result in the request being completed. The resulting TestDelegate::OnResponseCompleted() doesn't have a message loop to kill. Therefore, we now create a RunLoop and set the OnResponseCompleted closure so that an early completion will correctly mark the RunLoop as done. Bug: 873851 Change-Id: If67eaa1d141b0b3ee046d428a778106aa2287214 Reviewed-on: https://chromium-review.googlesource.com/1176632 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#583712} [modify] https://crrev.com/f05753ec9837b06105a621271ab2a124d37c0ac6/net/url_request/url_request_unittest.cc
,
Aug 16
Let's see if that works. The blocking issues are still valid though. I need some assistance running some diagnostics on the bot which happens to be the only place where the other issues reproduce.
,
Aug 16
,
Nov 29
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by achuith@chromium.org
, Aug 13