crash-reporter: only "main" service failures are captured |
||
Issue descriptioncurrently the anomaly collector watches for syslog entries like: init: [^ ]+ main process ([0-9]+) terminated with status [0-9]+ the problem is that the "main" keyword is not fixed. that only applies to the main `exec` or `script` stanza ... for `pre-start` or `post-start` stanzas, it'll be a different keyword. we need to update this regex to catch this variant otherwise failures in the `pre-start` stanza are being missed (which has happened more than once recently).
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/0c1cfec40e04b7af195fcb11f10c005e9f9da2e4 commit 0c1cfec40e04b7af195fcb11f10c005e9f9da2e4 Author: Mike Frysinger <vapier@chromium.org> Date: Thu Aug 23 20:20:38 2018 crash: anomaly_collector: expand service failure coverage We've only been matching the "main" stage from upstart service logs. This is the main exec/script phase that init scripts run (i.e. the main daemon/program). This could also be {pre,post}-{start,stop} which are the other phases which we've sometimes seen syntax errors or problems. BUG= chromium:873848 TEST=precq passes Change-Id: I53c4435c176a83197e1b5d0b802a942075c43400 Reviewed-on: https://chromium-review.googlesource.com/1173697 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Luigi Semenzato <semenzato@chromium.org> [modify] https://crrev.com/0c1cfec40e04b7af195fcb11f10c005e9f9da2e4/crash-reporter/crash_reporter_logs.conf [modify] https://crrev.com/0c1cfec40e04b7af195fcb11f10c005e9f9da2e4/crash-reporter/anomaly_collector.l [modify] https://crrev.com/0c1cfec40e04b7af195fcb11f10c005e9f9da2e4/crash-reporter/service_failure_collector_test.cc
,
Aug 23
|
||
►
Sign in to add a comment |
||
Comment 1 by vapier@chromium.org
, Aug 13