New issue
Advanced search Search tips

Issue 873841 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Build-Toolchain



Sign in to add a comment

We should enable -Wimplicit-fallthrough by default

Project Member Reported by g...@chromium.org, Aug 13

Issue description

-Wimplicit-fallthrough causes clang to emit a warning if a switch case falls through without an explicit fallthrough: https://godbolt.org/g/2yCjBS

This can catch many subtle bugs.

Chrome's had this on by default since February earlier this year (r533729). While it's likely not worthwhile to apply it to portage, platform2 and such seem like good candidates.
 

Sign in to add a comment