New issue
Advanced search Search tips

Issue 873824 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 15
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

OOBE animations.

Project Member Reported by alemate@chromium.org, Aug 13

Issue description

We need to add all the OOBE animations to M69.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/browser_internal/+/dc86a0199fd31f3068e13303ec86dcdde523c29a

commit dc86a0199fd31f3068e13303ec86dcdde523c29a
Author: Alexander Alekseev <alemate@google.com>
Date: Mon Aug 13 22:21:51 2018

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/src-internal.git/+/f727862b7b843cd9164854b15690cce172e95f49

commit f727862b7b843cd9164854b15690cce172e95f49
Author: Alexander Alekseev <alemate@google.com>
Date: Mon Aug 13 22:30:27 2018

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1476278a4864a9cfbdde1b8091b71aef5567fdb7

commit 1476278a4864a9cfbdde1b8091b71aef5567fdb7
Author: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Aug 14 02:24:02 2018

Roll src-internal 36668c6ef51c..f727862b7b84 (1 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/36668c6ef51c..f727862b7b84


Created with:
  gclient setdep -r src-internal@f727862b7b84

The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:873824 
TBR=mmoss@chromium.org

Change-Id: Ia2a701561718602b32cfbc8133fa45715a5f8596
Reviewed-on: https://chromium-review.googlesource.com/1173174
Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582800}
[modify] https://crrev.com/1476278a4864a9cfbdde1b8091b71aef5567fdb7/DEPS

Labels: Merge-Request-69
Requesting merge for two Cls above, and https://chromium-review.googlesource.com/c/chromium/src/+/1174986 .
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 15

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/013e2b63cd9f66416b36976dd7a0957c6b280e27

commit 013e2b63cd9f66416b36976dd7a0957c6b280e27
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Aug 15 04:25:40 2018

Chrome OS OOBE: add chromebox UI video, and switched all videos to 2x.

Bug:  873824 
Change-Id: I2f205fdca015150805768ed7adf5d2ff31344927
Reviewed-on: https://chromium-review.googlesource.com/1174986
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583167}
[modify] https://crrev.com/013e2b63cd9f66416b36976dd7a0957c6b280e27/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.css
[modify] https://crrev.com/013e2b63cd9f66416b36976dd7a0957c6b280e27/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html
[modify] https://crrev.com/013e2b63cd9f66416b36976dd7a0957c6b280e27/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.js

Status: Fixed (was: Untriaged)
Labels: -Merge-Review-69 Merge-Approved-69
Merge approved, M69.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 16

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fec30c195f0ba3a0ca5184ad7da103fe45332a4

commit 0fec30c195f0ba3a0ca5184ad7da103fe45332a4
Author: Alexander Alekseev <alemate@google.com>
Date: Thu Aug 16 01:06:30 2018

Chrome OS OOBE: add chromebox UI video, and switched all videos to 2x.

TBR=wzang@chromium.org

(cherry picked from commit 013e2b63cd9f66416b36976dd7a0957c6b280e27)

Bug:  873824 
Change-Id: I2f205fdca015150805768ed7adf5d2ff31344927
Reviewed-on: https://chromium-review.googlesource.com/1174986
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#583167}
Reviewed-on: https://chromium-review.googlesource.com/1176868
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#668}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/0fec30c195f0ba3a0ca5184ad7da103fe45332a4/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.css
[modify] https://crrev.com/0fec30c195f0ba3a0ca5184ad7da103fe45332a4/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html
[modify] https://crrev.com/0fec30c195f0ba3a0ca5184ad7da103fe45332a4/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.js

Sign in to add a comment