New issue
Advanced search Search tips

Issue 873814 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Intel GPU on Windows 10 GPU FYI bot failing

Project Member Reported by cblume@chromium.org, Aug 13

Issue description

On 2018-08-10 4:39 PM PDT, every build on this bot started failing pixel_tests.

The first failure was this build:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Exp%20Release%20%28Intel%20HD%20630%29/987

The 4 failing tests are:
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_DirectComposition_Video_MP4
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_DirectComposition_Video_VP9
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_Video_MP4
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_Video_VP9

These tests seem to revolve around video playback. Looking at the commits which landed in the failing build, some suspect CLs (in order of most likely to least via my guesses) are:
1.) media/gpu shared memory: update v4l2 UnalignedSharedMemory https://chromium-review.googlesource.com/c/1117692/
2.) Enable Windows NV12 overlays on waterfall https://chromium-review.googlesource.com/c/1170385/
3.) Roll src/third_party/angle 04c084dd3cf4..077cd858b2d4 (1 commits) https://chromium-review.googlesource.com/c/chromium/src/+/1171164
4.) Roll src/third_party/skia 6ed63968a391..4eac21fee047 (4 commits) https://chromium-review.googlesource.com/c/chromium/src/+/1171122
5.) Add RTCVideoDecoderAdapter, which can use any media::VideoDecoder. https://chromium-review.googlesource.com/c/chromium/src/+/1117837

I put #5 as last because magchen@ already looked into it and it seems to be innocent. I wanted to list it just for completeness.

I'm investigating now.
 
Cc: sunn...@chromium.org mattcary@chromium.org
mattcary@ - Could this be your patch? https://chromium-review.googlesource.com/c/chromium/src/+/1117692

sunnyps@ - Could this be your patch? https://chromium-review.googlesource.com/c/chromium/src/+/1170385
Status: Fixed (was: Available)
Looks like it was Sunny's patch.
I landed a revert [1] and the last 2 builds are green.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1173572
Likely we just need to update the revision number of these tests because now they go down a different format and might have slight diff in colors.
Right, that was my guess as well.
If this bot is using NV12 overlays some pixels will be slightly different colors.

Sign in to add a comment