New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 873804 link

Starred by 0 users
Status: Assigned
Owner:
█ updowndota@chromium.org
Last visit 26 days ago
Cc:
jen...@chromium.org
█ jrbarnette@chromium.org
afakhry@chromium.org
michae...@chromium.org
steve...@chromium.org
achuith@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

amd64-generic-telemetry bot should use CHROME_ORIGIN LOCAL_SOURCE

Project Member Reported by achuith@chromium.org, Aug 13 
This is the builder, which runs telemetry/perf unittests on ChromeOS:
https://cros-goldeneye.corp.google.com/chromeos/legoland/builderHistory?buildConfig=amd64-generic-telemetry&buildBranch=master

This is an informational builder monitored by gardeners. 

Once upon a time this built TOT cros with TOT chrome, presumably with CHROME_ORIGIN set to LOCAL_SOURCE. This allowed gardeners to detect breaking chrome changes right away. Currently, it looks like this bot uses prebuilt chrome, so breakages only show up after the PFQ rolls, as infrequently as a couple of times a week, which creates 2 problems:
1. Breaking telemetry changes are first seen in the PFQ instead of this bot.
2. If a change breaks a telemetry/perf unittest, there's now a large number of catapult/chrome CLs to consider.

I don't know exactly when this behavior changed, but it's in the last 2-3 months.

Comment 1 by jclinton@chromium.org, Aug 13

Owner: ----

Comment 2 by afakhry@chromium.org, Aug 13

Owner: dgarr...@chromium.org
Don, can you please triage this?

Comment 3 by dgarr...@chromium.org, Aug 13

Owner: afakhry@chromium.org
From the "config_dump" stage, I see:

    "chrome_binhost_only": false,
    "chrome_rev": null,
    "chrome_sdk": false,
    "chrome_sdk_build_chrome": true,
    "chrome_sdk_goma": true,


Looking at "config_dump" from the Chrome PFQ master:


    "chrome_binhost_only": false,
    "chrome_rev": "latest_release",
    "chrome_sdk": false,
    "chrome_sdk_build_chrome": true,
    "chrome_sdk_goma": true,


So, I suspect that chrome_rev needs to be set. That implies that this can be fixed with a small config change.

Comment 4 by afakhry@chromium.org, Aug 13

Owner: michae...@chromium.org
Status: Assigned (was: Untriaged)

Comment 5 by achuith@chromium.org, Aug 22

Cc: jen...@chromium.org
Owner: updowndota@chromium.org
Yue Li or Jenny - could you please take a look?

Comment 6 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 7 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Tests>Telemetry
►

Sign in to add a comment