New issue
Advanced search Search tips

Issue 873792 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 28
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug
Proj-Servicification



Sign in to add a comment

network_service_extensions_browsertests WebViewAPITest.TestWebRequestAPIWithHeaders is flaky (times out)

Project Member Reported by inglorion@chromium.org, Aug 13

Issue description

https://ci.chromium.org/buildbot/chromium.clang/ToTLinux/

Example failing builds:
https://ci.chromium.org/buildbot/chromium.clang/ToTLinux/3342
https://ci.chromium.org/buildbot/chromium.clang/ToTLinux/3339
https://ci.chromium.org/buildbot/chromium.clang/ToTLinux/3333

Snippet from logs:
[170/170] WebViewAPITest.TestWebRequestAPIWithHeaders (TIMED OUT)
Retrying 1 test (retry #3)
Still waiting for the following processes to finish:
	./extensions_browsertests --brave-new-test-launcher --cfi-diag=0 --data-path=/b/s/w/itQ60GFr/.org.chromium.Chromium.s2JVNT/dH76Kys --disable-gpu-process-for-dx12-vulkan-info-collection --enable-features=NetworkService --gtest_also_run_disabled_tests --gtest_filter=WebViewAPITest.TestWebRequestAPIWithHeaders --single_process --test-launcher-bot-mode --test-launcher-output=/b/s/w/itQ60GFr/.org.chromium.Chromium.s2JVNT/resultsFvdqih/test_results.xml --test-launcher-summary-output=/b/s/w/ioQgzB2V/output.json
Still waiting for the following processes to finish:
	./extensions_browsertests --brave-new-test-launcher --cfi-diag=0 --data-path=/b/s/w/itQ60GFr/.org.chromium.Chromium.s2JVNT/dH76Kys --disable-gpu-process-for-dx12-vulkan-info-collection --enable-features=NetworkService --gtest_also_run_disabled_tests --gtest_filter=WebViewAPITest.TestWebRequestAPIWithHeaders --single_process --test-launcher-bot-mode --test-launcher-output=/b/s/w/itQ60GFr/.org.chromium.Chromium.s2JVNT/resultsFvdqih/test_results.xml --test-launcher-summary-output=/b/s/w/ioQgzB2V/output.json
[ RUN      ] WebViewAPITest.TestWebRequestAPIWithHeaders
Xlib:  extension "RANDR" missing on display ":99".
DevTools listening on ws://127.0.0.1:42040/devtools/browser/02c48014-9ddb-49ea-be38-20c72851021f
BrowserTestBase received signal: Terminated. Backtrace:
#0 0x7f8ae7f8e05c base::debug::StackTrace::StackTrace()
#1 0x00000084e345 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f8adf0fdcb0 <unknown>
#3 0x7f8adf1b7c9d __poll
#4 0x7f8adde2cfe4 <unknown>
#5 0x7f8adde2d0ec g_main_context_iteration
#6 0x7f8ae7ef9812 base::MessagePumpGlib::Run()
#7 0x7f8ae7f1e685 base::RunLoop::Run()
#8 0x0000008ae237 ExtensionTestMessageListener::WaitUntilSatisfied()
#9 0x0000004bba99 extensions::WebViewAPITest::RunTest()
#10 0x0000004c0968 extensions::WebViewAPITest_TestWebRequestAPIWithHeaders_Test::RunTestOnMainThread()
#11 0x00000084dbb8 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#12 0x000000687887 extensions::ShellBrowserMainParts::PreMainMessageLoopRun()
#13 0x7f8ae6f2b661 content::BrowserMainLoop::PreMainMessageLoopRun()
#14 0x7f8ae72bc0b7 content::StartupTaskRunner::RunAllTasksNow()
#15 0x7f8ae6f2a074 content::BrowserMainLoop::CreateStartupTasks()
#16 0x7f8ae6f2dfe3 content::BrowserMainRunnerImpl::Initialize()
#17 0x7f8ae6f27ef4 content::BrowserMain()
#18 0x7f8ae7721849 content::ContentMainRunnerImpl::Run()
#19 0x7f8adea7f6fb service_manager::Main()
#20 0x7f8ae771fbb1 content::ContentMain()
#21 0x00000084d7ac content::BrowserTestBase::SetUp()
#22 0x0000004cb762 extensions::AppShellTest::SetUp()
#23 0x00000066261d testing::Test::Run()
#24 0x000000662ec0 testing::TestInfo::Run()
#25 0x0000006633d7 testing::TestCase::Run()
#26 0x00000066eda7 testing::internal::UnitTestImpl::RunAllTests()
#27 0x00000066e91d testing::UnitTest::Run()
#28 0x00000085be91 base::TestSuite::Run()
#29 0x0000004cb82c extensions::AppShellTestLauncherDelegate::RunTestSuite()
#30 0x000000851434 content::LaunchTests()
#31 0x0000004cb9a4 main
#32 0x7f8adf0e8f45 __libc_start_main
#33 0x00000047f02a _start
[171/171] WebViewAPITest.TestWebRequestAPIWithHeaders (TIMED OUT)

On builds between failures, the test takes about 1800ms to run.
 
Since the same test was disabled for being flaky in crbug.com/805903, I'll just do the same thing here.
Sounds good to me. Did you get a CL out for disabling yet?

Maybe also ping the folks on Issue 805903 about this failure since it seems very similar.
Oh, just found https://chromium-review.googlesource.com/c/chromium/src/+/1173406 for the disabling; let's push that through.
Components: Internals>Services>Network
Status: Untriaged (was: Unconfirmed)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4095e87b0b7af5e09a7dc4edeed28f89b82787f

commit a4095e87b0b7af5e09a7dc4edeed28f89b82787f
Author: inglorion <inglorion@chromium.org>
Date: Thu Aug 16 21:53:28 2018

Disable flaky WebViewAPITest.TestWebRequestAPIWithHeaders on Linux

This test was re-enabled in crrev.com/c/1110151, but creates noise on
the bots because it is flaky. Disabling it for now to stop the noise.

Bug:  873792 
Change-Id: I4c136a36d916bc8096ebba6d8d5839dea22533cf
Reviewed-on: https://chromium-review.googlesource.com/1173406
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Bob Haarman <inglorion@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583834}
[modify] https://crrev.com/a4095e87b0b7af5e09a7dc4edeed28f89b82787f/extensions/browser/guest_view/web_view/web_view_apitest.cc

Labels: -Pri-3 Hotlist-KnownIssue Pri-2
Owner: cduvall@chromium.org
Status: Assigned (was: Untriaged)
clark,can you help investigate?
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4158b22746fccf59a6cd2111bd6a1485a53c57fa

commit 4158b22746fccf59a6cd2111bd6a1485a53c57fa
Author: Clark DuVall <cduvall@chromium.org>
Date: Mon Aug 27 16:22:55 2018

Re-enable WebViewAPITest.TestWebRequestAPIWithHeaders in network service

I ran this a few hundred times with the ToTLinux build config, and
couldn't reproduce the flake. I'll monitor ToTLinux after this goes in
to see if the flake still happens.

Bug:  873792 
Change-Id: Ibe427a800d0c3eaea5b887ffda140c0f556c92bb
Reviewed-on: https://chromium-review.googlesource.com/1188590
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586277}
[modify] https://crrev.com/4158b22746fccf59a6cd2111bd6a1485a53c57fa/extensions/browser/guest_view/web_view/web_view_apitest.cc

Status: Fixed (was: Assigned)
This seems to be fixed now, please re-open if it flakes again.

Sign in to add a comment