Issue metadata
Sign in to add a comment
|
Regression: blackboxed scripts no longer omitted from console log source filenames
Reported by
axef...@gmail.com,
Aug 13
|
||||||||||||||||||||||
Issue description
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3518.0 Safari/537.36
Steps to reproduce the problem:
1. In a separate script, e.g. logger.js, override console.log, for example like so:
const _log = console.log;
console.log = (...a) => _log('LOGGER', ...a);
2. From any other script, and making sure logger.js has been imported/required/etc., write some console logs normally:
console.log('whatever');
3. In the developer tools, see that logger.js is the filename for every console log
4. Blackbox logger.js - as they should, the logged filenames change to reflect the sources of console.log statements within the rest of the code
5. Reload the page and look at the developer console
What is the expected behavior?
logger.js remains blackboxed, so the console should continue to omit it from the source filenames attributed to each log line.
What went wrong?
After reloading, even though the script remains blackboxed, the blackboxed script shows for each console log line. The only way to restore correct behaviour is to unblackbox logger.js, then re-blackbox it. Even so, any time the page is reloaded (which obviously is all the time during development), the problem will reoccur.
Did this work before? Yes Chrome 69 I think (68 for sure)
Chrome version: 70.0.3518.0 Channel: canary
OS Version: 10.0
Flash Version:
,
Aug 14
,
Aug 14
Reporter@ Thanks for the issue. Request you to provide a sample file where this issue can be reproduced which will help in further triaging. Thanks..
,
Aug 15
Are you saying you can't reproduce it? I report a lot of bugs for different products, and producing case-specific sample projects for everything reported is quite time-consuming, so I prefer to limit this to cases where the responder is not experiencing what I describe.
,
Aug 15
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 16
Thanks for the report. I was unable to reproduce after trying on Linux 68.0.3440.106 and 70.0.3522.0 using - <script src="..."> included in HTML - ES6 imports When I concat two scripts with a sourcemap and try to blackbox the one that redefines console.log, it somehow breaks the sourcemap on M70, but works fine on M68. I suspect sourcemaps and blackboxing might be interfering with each other.
,
Aug 17
As per comment #7, as this issue is assigned to Developer and dev is looking into this issue, removing 'Needs-Bisect' label. Please feel to add the label back if required. Thanks..
,
Aug 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d39387aa1a22141580687aa2ce6d3c33168f5137 commit d39387aa1a22141580687aa2ce6d3c33168f5137 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Sat Aug 25 21:33:47 2018 DevTools: update locations when new ranges calculated Blackbox manager may update location that we show for console message when top frame is blackboxed / unblackboxed. R=luoe@chromium.org Bug: chromium:873789 Change-Id: I8500d07877dfa6f08b57ccfb7236ad44e124137a Reviewed-on: https://chromium-review.googlesource.com/1183682 Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#586148} [modify] https://crrev.com/d39387aa1a22141580687aa2ce6d3c33168f5137/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/livelocation-main-frame-navigated-expected.txt [modify] https://crrev.com/d39387aa1a22141580687aa2ce6d3c33168f5137/third_party/blink/renderer/devtools/front_end/bindings/BlackboxManager.js
,
Aug 29
I was not able to reproduce this issue but I think that my fix should help. Could you check this issue in latests Canary?
,
Sep 21
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by axef...@gmail.com
, Aug 13