New issue
Advanced search Search tips

Issue 873787 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Update geo_language_provider network annotation description

Project Member Reported by nicolaso@chromium.org, Aug 13

Issue description

The `geo_language_provider` network annotation settings [1] should say:

"Users can disable this feature for translation requests in settings 'Languages', 'Language', 'Offer to translate'."

To match the text in the Chrome Browser Network Traffic Annotations document.

[1] https://cs.chromium.org/chromium/src/components/language/content/browser/geo_language_provider.cc?l=85&rcl=7c1077d1911e7fc1a00140952c1c1d1054978875
 
Owner: syoussefi@chromium.org
Owner: nicolaso@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd1ecc5214b44e7ad943bb7be60dedd710491e85

commit dd1ecc5214b44e7ad943bb7be60dedd710491e85
Author: Nicolas Ouellet-payeur <nicolaso@chromium.org>
Date: Fri Sep 07 16:40:22 2018

Update geo_language_provider network annotation settings description

Bug:  873787 
Change-Id: I591e0b158ca8e61e0f8ad9ac1099ac5e0ba28229
Reviewed-on: https://chromium-review.googlesource.com/1173401
Reviewed-by: Jia Meng <jiameng@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589544}
[modify] https://crrev.com/dd1ecc5214b44e7ad943bb7be60dedd710491e85/components/language/content/browser/geo_language_provider.cc
[modify] https://crrev.com/dd1ecc5214b44e7ad943bb7be60dedd710491e85/tools/traffic_annotation/summary/annotations.xml

Status: Fixed (was: Assigned)

Sign in to add a comment