New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 873782 link

Starred by 1 user
Status: Fixed
Owner:
lucmult@chromium.org
Closed: Aug 17
Cc:
weifangsun@chromium.org
slangley@chromium.org
█ mcirimele@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add scrim when showing a dialog

Project Member Reported by mcirimele@chromium.org, Aug 13 
Problem:
Dialogs are difficult to see in Files app. See attached screenshot.

Suggested solution: 
Add a scrim like the one used in Settings. See attached screenshot.

I've chatted with Sebastien and Weifang about this and it seems like a good improvement. Not sure how much work is involved in this, labeling M70 for now. 

Sebastien - could you help with the right spec for this?
files-no-scrim.png
614 KB View Download
settings-scrim.png
279 KB View Download

Comment 1 by mcirimele@chromium.org, Aug 13

Labels: CrOSFilesCategory-UI

Comment 2 by sgabr...@chromium.org, Aug 13 

Following WebUI specs, the shield should be 60% #000

Comment 3 by sgabr...@chromium.org, Aug 13

Owner: mcirimele@chromium.org
Re-assigning fro triage, let me know if you need anything else.

Comment 4 by weifangsun@chromium.org, Aug 13

Owner: ----

Comment 5 by slangley@chromium.org, Aug 15

Labels: -Pri-3 Pri-2
Owner: lucmult@chromium.org
Status: Assigned (was: Available)
Luciano - can you take a look?

Comment 6 by lucmult@chromium.org, Aug 15

Labels: OS-Chrome
ACK, I'll check.

Comment 7 by lucmult@chromium.org, Aug 16 

To be clear it will affect all dialog we use, including the Webstore (see attached screenshots).
Selection_049.png
124 KB View Download
Selection_050.png
79.5 KB View Download

Comment 8 by lucmult@chromium.org, Aug 16

Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0ff8ae1e40b681266b988e421e8ddffc9d87ef5

commit d0ff8ae1e40b681266b988e421e8ddffc9d87ef5
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Thu Aug 16 07:48:59 2018

Add background color for dialog

Add background color for the dialog component to make dialog more
visible as requested in the bug.

Bug:  873782 
Change-Id: I9021ee5613309d7fa974eee816aeb83f47fdac44
Reviewed-on: https://chromium-review.googlesource.com/1177285
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583578}
[modify] https://crrev.com/d0ff8ae1e40b681266b988e421e8ddffc9d87ef5/ui/file_manager/file_manager/foreground/css/common.css

Comment 10 by lucmult@chromium.org, Aug 17

Status: Fixed (was: Started)
►

Sign in to add a comment