WebRtcAudioDebugRecordingsBrowserTest.*CallWithAudioDebugRecordings flakily fail in site-per-process mode |
||
Issue descriptionSite Isolation shipped in M67 to all desktop platforms. Site Isolation means that 1) a website might use more than one renderer process and 2) a SpareRenderProcessHostManager might proactively keep one extra renderer process alive. These extra processes are incompatible with an assumption made in content/browser/webrtc/webrtc_audio_debug_recordings_browsertest.cc where GetRenderProcessHostId DCHECKs that there is only one renderer process. I think the fix should be fairly simple - to delete GetRenderProcessHostId. Note that the tests are currently disabled on Linux due to unrelated flakiness - see issue 871182.
,
Aug 13
,
Aug 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e2522c70a52a9859ec1bc4cfb0736d08d9991cb commit 4e2522c70a52a9859ec1bc4cfb0736d08d9991cb Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Tue Aug 14 16:43:30 2018 Test should use the process of the main frame. This CL deletes the GetRenderProcessHostId helper function, which return the pid of a renderer process, but would only work if there is exactly a single renderer process present (making it problematic under Site Isolation where multiple renderers might be present, including the spare renderer). The CL replaces GetRenderProcessHostId with directly getting the pid of the main frame's renderer. Bug: 873780 Change-Id: Ic26ff3ffaca5045e5e5e5ad2f701dfff7cdb90be Reviewed-on: https://chromium-review.googlesource.com/1173351 Reviewed-by: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by: Patrik Höglund <phoglund@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#582941} [modify] https://crrev.com/4e2522c70a52a9859ec1bc4cfb0736d08d9991cb/content/browser/webrtc/webrtc_audio_debug_recordings_browsertest.cc
,
Aug 14
|
||
►
Sign in to add a comment |
||
Comment 1 by lukasza@chromium.org
, Aug 13