New issue
Advanced search Search tips

Issue 873777 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

password_manager:: PostHSTSQueryForHostAndRequestContext talks to URLRequestContext.

Project Member Reported by morlovich@chromium.org, Aug 13

Issue description

Called from chrome/browser/password_manager/chrome_password_manager_client.cc to query HSTS.

Might be important, and I am not sure if we have an API for that.

 
Cc: mattm@chromium.org
Usage seems to be:
https://cs.chromium.org/chromium/src/components/password_manager/core/browser/http_password_store_migrator.h?rcl=5202b90d8de13309d30bbc60be18f20be19f7276&l=24

Some preconnect stuff seems to be using the underlying method as well, though some of that might be replaced by the new preconnect API....

@mattm: I noticed in your snippets that you were looking for S13n stuff, and you're an SSL expert, so this might be something to consider.

Cc: eroman@chromium.org
Labels: Hotlist-KnownIssue OS-Chrome OS-Linux OS-Mac OS-Windows
Note the API that would be added to this would be used to get net-internals working with network service.
Owner: morlovich@chromium.org
Status: Assigned (was: Untriaged)
Looks like one more owner of Profile::GetRequestContext calling into this showed up just last week :(

Anyway, if noone else is interested I may as well take this.

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85b7546763e8be89e6c0fe50ee528650bea12a89

commit 85b7546763e8be89e6c0fe50ee528650bea12a89
Author: Maks Orlovich <morlovich@chromium.org>
Date: Wed Aug 29 14:46:05 2018

Port HSTS querying to Network Service APIs

Direct access to URLRequestContext, including its
net::TransportSecurityState is going away; things should
go through NetworkContext now.

Bug:  873777 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ibfb52cd027f5b417e05a35baf902ad81ba4df24b
Reviewed-on: https://chromium-review.googlesource.com/1183990
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587111}
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/chrome/browser/password_manager/password_manager_test_base.cc
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/chrome/browser/password_manager/password_store_factory.cc
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/components/password_manager/core/browser/DEPS
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/components/password_manager/core/browser/hsts_query.cc
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/components/password_manager/core/browser/hsts_query.h
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/components/password_manager/core/browser/hsts_query_unittest.cc
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/components/password_manager/core/browser/http_password_store_migrator.cc
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/components/password_manager/core/browser/http_password_store_migrator.h
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/components/password_manager/core/browser/http_password_store_migrator_unittest.cc
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/components/password_manager/core/browser/password_manager_client.cc
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/components/password_manager/core/browser/password_manager_client.h
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/components/password_manager/core/browser/password_manager_util.cc
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/components/password_manager/core/browser/password_manager_util.h
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/components/password_manager/core/browser/password_manager_util_unittest.cc
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/services/network/network_context.cc
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/services/network/network_context.h
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/services/network/network_context_unittest.cc
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/services/network/public/mojom/network_context.mojom
[modify] https://crrev.com/85b7546763e8be89e6c0fe50ee528650bea12a89/services/network/test/test_network_context.h

Status: Fixed (was: Started)

Sign in to add a comment