New issue
Advanced search Search tips

Issue 873773 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Add ash PRESUBMIT.py to ban aura::Env::GetInstance()

Project Member Reported by jamescook@chromium.org, Aug 13

Issue description

And tell people to use ash::Shell::aura_env()

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c005037166afabb92dc607ca8c0f9886a230284

commit 6c005037166afabb92dc607ca8c0f9886a230284
Author: James Cook <jamescook@chromium.org>
Date: Mon Aug 13 23:03:46 2018

Add ash/PRESUBMIT.py to ban aura::Env::GetInstance() use

aura::Env::GetInstance is banned in //ash because it will return the
wrong aura::Env in SingleProcessMash mode. See //ash/README.md.

The code is based on the banned function code in src/PRESUBMIT.py.
I decided a little code duplication was better than trying to support
a mix of whitelist and blacklist directories in the global banned
function list.

Bug:  873773 
Change-Id: I646f10dc58cc1ea030652c490547834143023e68
Reviewed-on: https://chromium-review.googlesource.com/1173404
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582733}
[add] https://crrev.com/6c005037166afabb92dc607ca8c0f9886a230284/ash/PRESUBMIT.py

Status: Fixed (was: Started)

Sign in to add a comment