Bring the necessary part of PlatformEventDispatcher functionality into DeviceMotionEventPump and DeviceOrientationEventPump |
|||
Issue descriptionSince DeviceMotionEventPump and DeviceOrientationEventPump are now owned by corresponding controllers, there is no need for the event pumps to have all the logic from PlatformEventDispatcher. This ticket covers decoupling DeviceMotionEventPump and DeviceOrientationEventPump from PlatformEventDispatcher and implementing the necessary controller-related logic in the event pumps.
,
Aug 23
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e6f589030a6c80e7b89822b4fd07c6ee8f7e567 commit 6e6f589030a6c80e7b89822b4fd07c6ee8f7e567 Author: Oksana Zhuravlova <oksamyt@chromium.org> Date: Wed Sep 05 19:40:14 2018 Decouple DeviceMotionEventPump from PlatformEventDispatcher This change implements the controller management logic in DeviceMotionEventPump and removes the dependency on PlatformEventDispatcher. Bug: 873761 Change-Id: I520987c38877f0adfc4cbbce75bff2a36e5b47fe Reviewed-on: https://chromium-review.googlesource.com/1187517 Reviewed-by: Tim Volodine <timvolodine@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#588970} [modify] https://crrev.com/6e6f589030a6c80e7b89822b4fd07c6ee8f7e567/third_party/blink/renderer/modules/device_orientation/device_motion_controller.cc [modify] https://crrev.com/6e6f589030a6c80e7b89822b4fd07c6ee8f7e567/third_party/blink/renderer/modules/device_orientation/device_motion_event_pump.cc [modify] https://crrev.com/6e6f589030a6c80e7b89822b4fd07c6ee8f7e567/third_party/blink/renderer/modules/device_orientation/device_motion_event_pump.h [modify] https://crrev.com/6e6f589030a6c80e7b89822b4fd07c6ee8f7e567/third_party/blink/renderer/modules/device_orientation/device_motion_event_pump_unittest.cc
,
Oct 8
|
|||
►
Sign in to add a comment |
|||
Comment 1 by reillyg@chromium.org
, Aug 15Owner: oksamyt@chromium.org
Status: Assigned (was: Untriaged)