New issue
Advanced search Search tips

Issue 873760 link

Starred by 1 user
Status: Fixed
Owner:
obru...@igalia.com
Closed: Aug 20
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 850004



Sign in to add a comment

[css-logical] CSS logical shorthands are not serialized

Project Member Reported by obru...@igalia.com, Aug 13 
Run this code:

  var el = document.body;
  el.style.borderBlock = "5px solid blue";
  el.style.borderBlock; // ""
  getComputedStyle(el).borderBlock; // ""

According to https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue, they should produce "5px solid blue".

For getComputedStyle there was some controversy in the past, but there is a recent resolution to do the same, see https://github.com/w3c/csswg-drafts/issues/2529#issuecomment-402386896
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c130d2da974789f06b85241e188a88dc5c9f43f

commit 0c130d2da974789f06b85241e188a88dc5c9f43f
Author: Oriol Brufau <obrufau@igalia.com>
Date: Fri Aug 17 11:58:40 2018

[css-logical] Allow CSS logical shorthands to be serialized in inline and computed styles

Spec: https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue

BUG= 873760 

TEST=external/wpt/css/css-logical/logical-box-border-color.html
TEST=external/wpt/css/css-logical/logical-box-border-shorthands.html
TEST=external/wpt/css/css-logical/logical-box-border-style.html
TEST=external/wpt/css/css-logical/logical-box-border-width.html
TEST=external/wpt/css/css-logical/logical-box-inset.html
TEST=external/wpt/css/css-logical/logical-box-margin.html
TEST=external/wpt/css/css-logical/logical-box-padding.html

Change-Id: I60fca339c419d1d19eb6b31f0426c11f9d1cf95f
Reviewed-on: https://chromium-review.googlesource.com/1176084
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#584027}
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-box-border-color-expected.txt
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-box-border-shorthands-expected.txt
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-box-border-style-expected.txt
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-box-border-width-expected.txt
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-box-inset-expected.txt
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-box-margin-expected.txt
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-box-padding-expected.txt
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/resources/test-box-properties.js
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/WebKit/LayoutTests/webexposed/css-property-listing-expected.txt
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/blink/renderer/core/css/CSSProperties.json5
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/blink/renderer/core/css/properties/shorthands/border_block_color_custom.cc
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/blink/renderer/core/css/properties/shorthands/border_block_custom.cc
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/blink/renderer/core/css/properties/shorthands/border_block_style_custom.cc
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/blink/renderer/core/css/properties/shorthands/border_block_width_custom.cc
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/blink/renderer/core/css/properties/shorthands/border_inline_color_custom.cc
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/blink/renderer/core/css/properties/shorthands/border_inline_custom.cc
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/blink/renderer/core/css/properties/shorthands/border_inline_style_custom.cc
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/blink/renderer/core/css/properties/shorthands/border_inline_width_custom.cc
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/blink/renderer/core/css/properties/shorthands/inset_block_custom.cc
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/blink/renderer/core/css/properties/shorthands/inset_custom.cc
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/blink/renderer/core/css/properties/shorthands/inset_inline_custom.cc
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/blink/renderer/core/css/properties/shorthands/margin_block_custom.cc
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/blink/renderer/core/css/properties/shorthands/margin_inline_custom.cc
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/blink/renderer/core/css/properties/shorthands/padding_block_custom.cc
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/blink/renderer/core/css/properties/shorthands/padding_inline_custom.cc
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/blink/renderer/core/css/style_property_serializer.cc
[modify] https://crrev.com/0c130d2da974789f06b85241e188a88dc5c9f43f/third_party/blink/renderer/core/css/style_property_serializer.h

Comment 2 by obru...@igalia.com, Aug 20

Status: Fixed (was: Assigned)
►

Sign in to add a comment