New issue
Advanced search Search tips

Issue 873759 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 18
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature

Blocking:
issue 764085



Sign in to add a comment

[zlib][arm] Compression: optimize insert_string hash function

Project Member Reported by cavalcantii@chromium.org, Aug 13

Issue description

Intel has this landed since late 2014, should help compression (and we already got the groundwork done when we landed the ARMv8-1 crypto crc32 function).
 
Blocking: 764085
Summary: [zlib][arm] Compression: optimize insert_string hash function (was: [zlib][arm] Optimize insert_string hash function)
Performance charts (average gain was 24% for A72 and 8% for A53).
Pixel_ insert_string compression speed.png
9.1 KB View Download
Rock64_ insert_string compression speed.png
9.8 KB View Download
MotoX4_ insert_string compression speed.png
10.0 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1364a33fe0f2b9588a2d018f62ff4d966a525f37

commit 1364a33fe0f2b9588a2d018f62ff4d966a525f37
Author: Adenilson Cavalcanti <adenilson.cavalcanti@arm.com>
Date: Wed Aug 15 01:06:05 2018

ARM optimized insert_string

Using a faster hash function yields a considerable performance boost
in compression (average 8% on A53 and 24% on A72).

This change was enabled by previous patch with optimized crc32 using
ARMv8-1 crypto extensions for performing CPU feature detection
(so won't help older ARMv7 SoCs).

Bug:  873759 
Change-Id: I88ece549a63d923beef4f96a046acdf09e529784
Reviewed-on: https://chromium-review.googlesource.com/1173262
Reviewed-by: Chris Blume <cblume@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583113}
[modify] https://crrev.com/1364a33fe0f2b9588a2d018f62ff4d966a525f37/third_party/zlib/crc32_simd.c
[modify] https://crrev.com/1364a33fe0f2b9588a2d018f62ff4d966a525f37/third_party/zlib/crc32_simd.h
[modify] https://crrev.com/1364a33fe0f2b9588a2d018f62ff4d966a525f37/third_party/zlib/deflate.c

Status: Fixed (was: Started)

Sign in to add a comment