New issue
Advanced search Search tips

Issue 873746 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

page_resource_data_use_ never erases old entries

Project Member Reported by csharrison@chromium.org, Aug 13

Issue description

Many web pages have a single-page architecture, so we want to avoid memory leaks in that scenario.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30c255498a700b299da7723f2b6369ae0464a2f3

commit 30c255498a700b299da7723f2b6369ae0464a2f3
Author: John Delaney <johnidel@chromium.org>
Date: Thu Aug 16 16:51:47 2018

Send per-resource updates to PageLoadMetrics

Send data use updates per resource from renderer to browser. This
will allow the browser process to aggregate per-resource information
and will keep feature specific logic out of core PageLoadMetrics
code.

Bug:  873746 , 851543 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I34a617c8f1212d9d9ec157de16d65379340b1697
Reviewed-on: https://chromium-review.googlesource.com/1164222
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583691}
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.cc
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/chrome/browser/page_load_metrics/page_load_metrics_test_waiter.cc
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/chrome/browser/page_load_metrics/page_load_metrics_test_waiter.h
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/chrome/browser/page_load_metrics/page_load_tracker.h
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/chrome/common/page_load_metrics/page_load_metrics.mojom
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/chrome/renderer/page_load_metrics/fake_page_timing_sender.cc
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/chrome/renderer/page_load_metrics/fake_page_timing_sender.h
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/chrome/renderer/page_load_metrics/page_resource_data_use.cc
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/chrome/renderer/page_load_metrics/page_resource_data_use.h
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/chrome/renderer/page_load_metrics/page_timing_sender.h
[modify] https://crrev.com/30c255498a700b299da7723f2b6369ae0464a2f3/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Status: Fixed (was: Untriaged)
Owner: johnidel@chromium.org

Sign in to add a comment