New issue
Advanced search Search tips

Issue 873743 link

Starred by 1 user
Status: Fixed
Owner:
msw@chromium.org
Closed: Aug 15
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 841020



Sign in to add a comment

ws: Capture not released from TouchSelectionControllerImpl::EditingHandleView

Project Member Reported by msw@chromium.org, Aug 13 
ws: Capture not released from TouchSelectionControllerImpl::EditingHandleView

On ToT #582215 linux-chromeos builds (or similar on device)
(1) Run chrome --touch-devices=ID --ash-touch-hud (get ID from "xinput list")
(2) Open the KSV app window (Ctrl-Alt-/)
(3) Type some text
(4) Select all the text by long-tap touching the text
(5) Drag one of the touch text editing handles
(6) Try to drag the other touch text editing handle, or touch anything else
Expected: Touches elsewhere work as expected.
Actual: Touches anywhere else are not respected.

Something similar happens when you simply drag the single touch handle for caret placement:
Touching elsewhere works, but the touch editing handle is not destroyed when clicking back, etc.
(I'm hoping that has the same underlying defect as the issue above)

AFAICT, EditingHandleView's ReleaseCapture is not being respected by the window service.
All subsequent touch events are still sent to the touch text editing handle window.
(it continues consuming touch events even after touch drag/scroll release)
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8812d56315174245afaa979c7f4ecaddf35e7bf0

commit 8812d56315174245afaa979c7f4ecaddf35e7bf0
Author: Mike Wasserman <msw@chromium.org>
Date: Wed Aug 15 19:38:39 2018

ws: Fix capture release on window destruction

The capture window should only be cleared if it's part of the client.

Fixes the case where dragging a touch edit handle closes the context menu.
(the context menu closing shouldn't reset client-side touch handle capture)
(otherwise, capture release isn't sent to the ws when ending the touch drag)

Bug:  873743 
Test: Automated, KSV (Ctrl-Alt-/) touch text edit handles work.
Change-Id: I4e28115de92f7b8cb0355b6a9e4c0b470634ad2b
Reviewed-on: https://chromium-review.googlesource.com/1176073
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583358}
[modify] https://crrev.com/8812d56315174245afaa979c7f4ecaddf35e7bf0/services/ui/ws2/server_window.cc
[modify] https://crrev.com/8812d56315174245afaa979c7f4ecaddf35e7bf0/ui/aura/mus/capture_synchronizer.cc
[modify] https://crrev.com/8812d56315174245afaa979c7f4ecaddf35e7bf0/ui/aura/mus/window_tree_client_unittest.cc

Comment 2 by msw@chromium.org, Aug 15

Status: Fixed (was: Assigned)
►

Sign in to add a comment