New issue
Advanced search Search tips

Issue 873742 link

Starred by 1 user
Status: Duplicate
Merged: issue 647781
Owner: ----
Closed: Aug 13
Cc:
msw@chromium.org
jamescook@chromium.org
sky@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Short-cut keys and F-based accelerators not working in Mash

Project Member Reported by rcui@chromium.org, Aug 13 
Chrome Version: 70.0.3522.0
OS: Chrome OS

What steps will reproduce the problem?
(1) Run chrome with --enable-features=Mash 
(2) Press refresh, volume up, volume down short-cut keys

What is the expected result? Described actions.

What happens instead? Nothing

Accelerator actions that depend on F-keys (like screenshot - ctrl-f5) are also not working.

Works when running without --enable-features=Mash.

Comment 1 by rcui@chromium.org, Aug 13 

Screenshot functionality (ctrl-f5, ctrl-shift-f5) is blocked on crbug.com/557397, but the issue here is we are not actually registering the accelerator action.

Comment 2 by rcui@chromium.org, Aug 13

Labels: -Pri-3 Pri-2

Comment 3 by jamescook@chromium.org, Aug 13 

I can repro on device. The keys seem to be stuck as F-keys and not remapped to their media-key equivalents. For example, pressing the "<-" back key opens Help, which is what F1 would do on a standard keyboard.

Hope that helps.

Comment 4 by jamescook@chromium.org, Aug 13

Labels: -OS-iOS OS-Chrome

Comment 5 by rcui@chromium.org, Aug 13

Mergedinto: 647781
Status: Duplicate (was: Untriaged)
Thanks.  Looking into the media-key functionality, it depends on an EventRewriterChromeOS class that only gets registered in non-Mash mode: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/chrome_browser_main_chromeos.cc?rcl=33cd2bccd7dbd33dfddbe3fb4f4c8a6b1a7e4617&l=1039.  Marking this bug as a dupe of crbug.com/647781, which tracks enabling event rewriting in Mash.
►

Sign in to add a comment