New issue
Advanced search Search tips

Issue 873732 link

Starred by 1 user
Status: Verified
Owner:
benchan@chromium.org
Closed: Aug 14
Cc:
mortonm@chromium.org
dhadd...@chromium.org
harpreet@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Daisy-Gobi3k mdoem: INIT_ERROR: Cannot find cellular device in shill.

Project Member Reported by dsunk...@chromium.org, Aug 13 
DUT: chromeos1-row2-rack7-host1

Shill is unable to find cellular device. 

2018-08-13T11:52:50.118369+00:00 ERR shill[1173]: [ERROR:modem_classic.cc(66)] Unsupported cellular modem type: 4294967295
2018-08-13T11:52:50.117671+00:00 ERR shill[1173]: [ERROR:object_proxy.cc(580)] Failed to call method: org.freedesktop.DBus.Properties.GetAll: object_path= /org/chromium/ModemManager/Gobi/0: org.freedesktop.DBus.Error.AccessDenied: Rejected send message, 1 matched rules; type="method_call", sender=":1.7" (uid=20104 pid=1173 comm="/usr/bin/shill --log-level=0 --log-scopes= --vmodu") interface="org.freedesktop.DBus.Properties" member="GetAll" error name="(unset)" requested_reply="0" destination="org.chromium.ModemManager" (uid=210 pid=2402 comm="cromo ")
2018-08-13T11:52:50.117713+00:00 ERR shill[1173]: [ERROR:dbus_method_invoker.h(112)] CallMethodAndBlockWithTimeout(...): Domain=dbus, Code=org.freedesktop.DBus.Error.AccessDenied, Message=Rejected send message, 1 matched rules; type="method_call", sender=":1.7" (uid=20104 pid=1173 comm="/usr/bin/shill --log-level=0 --log-scopes= --vmodu") interface="org.freedesktop.DBus.Properties" member="GetAll" error name="(unset)" requested_reply="0" destination="org.chromium.ModemManager" (uid=210 pid=2402 comm="cromo ")
2018-08-13T11:52:50.117745+00:00 ERR shill[1173]: [ERROR:chromeos_dbus_properties_proxy.cc(59)] GetAll failed on org.freedesktop.ModemManager.Modem: org.freedesktop.DBus.Error.AccessDenied Rejected send message, 1 matched rules; type="method_call", sender=":1.7" (uid=20104 pid=1173 comm="/usr/bin/shill --log-level=0 --log-scopes= --vmodu") interface="org.freedesktop.DBus.Properties" member="GetAll" error name="(unset)" requested_reply="0" destination="org.chromium.ModemManager" (uid=210 pid=2402 comm="cromo ")
this looks like a regression of the shill sandbox

Logs @
https://stainless.corp.google.com/search?view=list&first_date=2018-07-17&last_date=2018-08-13&test=%5Ecellular_Identifiers%5C.gobi3k%24&hostname=chromeos1-row2-rack7-host1&status=FAIL&status=ERROR&status=ABORT&exclude_cts=true&exclude_not_run=false&exclude_non_release=true&exclude_au=true&exclude_acts=true&exclude_retried=true&exclude_non_production=false

Comment 1 by benchan@chromium.org, Aug 13

Cc: -benchan@chromium.org mortonm@chromium.org
Owner: benchan@chromium.org
Status: Started (was: Available)
shill now runs as a non-root user, so cromo needs to allow the shill user to interact with its D-Bus API
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0383dbecf29dc4b14d0cfb83f29350144c06a58e

commit 0383dbecf29dc4b14d0cfb83f29350144c06a58e
Author: Ben Chan <benchan@chromium.org>
Date: Tue Aug 14 00:48:58 2018

cromo: allows shill running as 'shill' user to interact with cromo

shill is now running as the 'shill' user instead of root. This CL
updates the cromo D-Bus policy to allow the 'shill' user to interact
with cromo.

BUG= chromium:873732 
TEST=Run cellular_ota tests on a DUT with a Gobi 3K modem.

Change-Id: I5c27c18b3acb6521bdd62b133f2c64d613d2644a
Reviewed-on: https://chromium-review.googlesource.com/1173066
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Micah Morton <mortonm@chromium.org>

[modify] https://crrev.com/0383dbecf29dc4b14d0cfb83f29350144c06a58e/cromo/org.chromium.ModemManager.conf

Comment 3 by benchan@chromium.org, Aug 14

Status: Fixed (was: Started)
Is this really needed for M-69?

Comment 4 by dsunk...@chromium.org, Sep 13

Status: Verified (was: Fixed)
Tests now does not fail on this error. They fail with different issue though.
►

Sign in to add a comment