Chromebook password field stuck on EasyUnlock prompts |
||||||||||
Issue descriptionCurrently on canary channel Chrome 70.0.3519.3 on Pixelbook Steps to reproduce (on Pixelbook at least): 1) Make sure EasyUnlock is enabled 2) Lock Chromebook 3) Unlock phone --> Password field should read "Click your photo" 4) Lock phone --> Password field reads "Click your photo". Should it now read "Password"? There is a dialog window that reads "Your phone is locked. Unlock it to enter." 5) Click photo --> Password field reads "Signing in..." The prompt will continue to read "Signing in...". - If I unlock my phone and click the picture again, I can get in. - However, if I click the lock icon, which forces you to manually enter a password to continue, the prompt continues to read "Signing in..." and I have to sign out completely. I would expect that once my phone is locked, I would be given the option to enter my password. Also, I would expect that clicking my picture would only (possibly) give a dialog window with EasyUnlock instructions.
,
Sep 14
,
Sep 14
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f59e3a0112c5b09bee04402bbbcdb89236efd578 commit f59e3a0112c5b09bee04402bbbcdb89236efd578 Author: James Hawkins <jhawkins@chromium.org> Date: Tue Sep 18 16:03:22 2018 Revert "LoginAuthUserView: Display "Signing in..." when the user activates SmartLock." This reverts commit d3433075a470b4c7a4e50ff33b6485989799f7cc. With this change in place, if an auth error occurs after the user attempts the Smart Lock sign-in/unlock operation, the user is unable to enter their password because the 'Signing in...' text is still displayed in the password input field. Rolling this forward requires handling that auth error state. Original change's description: > LoginAuthUserView: Display "Signing in..." when the user activates SmartLock. > > This change also animates the ellipses while the operation is executing. > > R=jdufault@chromium.org > > Bug: 845313 > Test: LoginAuthUserViewUnittest.PressReturnWithTapToUnlockEnabled > Change-Id: I5054a49177049070db5169e4c7e594dfe0a45baf > Reviewed-on: https://chromium-review.googlesource.com/1072804 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: James Hawkins <jhawkins@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561932} R=jdufault@chromium.org Bug: 873723 Test: none Change-Id: I0fdf6a491c991983bb0eea1c151d5d30851e4ee5 Reviewed-on: https://chromium-review.googlesource.com/1227293 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#592060} [modify] https://crrev.com/f59e3a0112c5b09bee04402bbbcdb89236efd578/ash/ash_strings.grd [modify] https://crrev.com/f59e3a0112c5b09bee04402bbbcdb89236efd578/ash/login/ui/login_auth_user_view.cc [modify] https://crrev.com/f59e3a0112c5b09bee04402bbbcdb89236efd578/ash/login/ui/login_auth_user_view.h [modify] https://crrev.com/f59e3a0112c5b09bee04402bbbcdb89236efd578/ash/login/ui/login_auth_user_view_unittest.cc
,
Sep 18
,
Sep 19
This bug requires manual review: There is .grd file changes and we are only 26 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 19
Merge reviewer: the revert just removes an added string, so we shouldn't have any problems there.
,
Sep 21
,
Sep 24
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e017ac36996def7653b0b2e86abbab16e52b2448 commit e017ac36996def7653b0b2e86abbab16e52b2448 Author: James Hawkins <jhawkins@chromium.org> Date: Wed Sep 26 23:56:35 2018 Revert "LoginAuthUserView: Display "Signing in..." when the user activates SmartLock." This reverts commit d3433075a470b4c7a4e50ff33b6485989799f7cc. With this change in place, if an auth error occurs after the user attempts the Smart Lock sign-in/unlock operation, the user is unable to enter their password because the 'Signing in...' text is still displayed in the password input field. Rolling this forward requires handling that auth error state. Original change's description: > LoginAuthUserView: Display "Signing in..." when the user activates SmartLock. > > This change also animates the ellipses while the operation is executing. > > R=jdufault@chromium.org > > Bug: 845313 > Test: LoginAuthUserViewUnittest.PressReturnWithTapToUnlockEnabled > Change-Id: I5054a49177049070db5169e4c7e594dfe0a45baf > Reviewed-on: https://chromium-review.googlesource.com/1072804 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: James Hawkins <jhawkins@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561932} R=jdufault@chromium.org TBR=jhawkins@chromium.org (cherry picked from commit f59e3a0112c5b09bee04402bbbcdb89236efd578) Bug: 873723 Test: none Change-Id: I0fdf6a491c991983bb0eea1c151d5d30851e4ee5 Reviewed-on: https://chromium-review.googlesource.com/1227293 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#592060} Reviewed-on: https://chromium-review.googlesource.com/1246950 Reviewed-by: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#691} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/e017ac36996def7653b0b2e86abbab16e52b2448/ash/ash_strings.grd [modify] https://crrev.com/e017ac36996def7653b0b2e86abbab16e52b2448/ash/login/ui/login_auth_user_view.cc [modify] https://crrev.com/e017ac36996def7653b0b2e86abbab16e52b2448/ash/login/ui/login_auth_user_view.h [modify] https://crrev.com/e017ac36996def7653b0b2e86abbab16e52b2448/ash/login/ui/login_auth_user_view_unittest.cc
,
Sep 26
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e017ac36996def7653b0b2e86abbab16e52b2448 Commit: e017ac36996def7653b0b2e86abbab16e52b2448 Author: jhawkins@chromium.org Commiter: jhawkins@chromium.org Date: 2018-09-26 23:56:35 +0000 UTC Revert "LoginAuthUserView: Display "Signing in..." when the user activates SmartLock." This reverts commit d3433075a470b4c7a4e50ff33b6485989799f7cc. With this change in place, if an auth error occurs after the user attempts the Smart Lock sign-in/unlock operation, the user is unable to enter their password because the 'Signing in...' text is still displayed in the password input field. Rolling this forward requires handling that auth error state. Original change's description: > LoginAuthUserView: Display "Signing in..." when the user activates SmartLock. > > This change also animates the ellipses while the operation is executing. > > R=jdufault@chromium.org > > Bug: 845313 > Test: LoginAuthUserViewUnittest.PressReturnWithTapToUnlockEnabled > Change-Id: I5054a49177049070db5169e4c7e594dfe0a45baf > Reviewed-on: https://chromium-review.googlesource.com/1072804 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: James Hawkins <jhawkins@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561932} R=jdufault@chromium.org TBR=jhawkins@chromium.org (cherry picked from commit f59e3a0112c5b09bee04402bbbcdb89236efd578) Bug: 873723 Test: none Change-Id: I0fdf6a491c991983bb0eea1c151d5d30851e4ee5 Reviewed-on: https://chromium-review.googlesource.com/1227293 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#592060} Reviewed-on: https://chromium-review.googlesource.com/1246950 Reviewed-by: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#691} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by jhawkins@chromium.org
, Aug 13Owner: jhawkins@chromium.org
Status: Assigned (was: Untriaged)