New issue
Advanced search Search tips

Issue 873710 link

Starred by 1 user
Status: Fixed
Owner:
martinkr@google.com
Closed: Aug 27
Cc:
kenrb@chromium.org
martinkr@google.com
engedy@chromium.org
ssoneff@google.com
kpaulhamus@chromium.org
jdoerrie@chromium.org
mknowles@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Re-enable platform authenticators for AuthenticatorAttachment::kUndefined

Project Member Reported by martinkr@google.com, Aug 13 
Platform authenticators are currently disabled in the MakeCredentialRequestHandler for requests that have AuthenticatorAttachment::kUndefined set in AuthenticatorSelectionCriteria, so that Touch ID will not show a fingerprint prompt for requests that could be handled by an external authenticator, as long as there is no UI integration for Touch ID. After UI integration is complete, this needs to be reverted.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23355d599daab8e118873292d023c6db26f4b098

commit 23355d599daab8e118873292d023c6db26f4b098
Author: Martin Kreichgauer <martinkr@google.com>
Date: Thu Aug 23 22:40:31 2018

fido: reenable Touch ID for kAny attachment if transport selection UI is enabled

We previously disabled the MakeCredential operation for Touch ID if
AuthenticatorAttachment was set to kAny in order to avoid having the
fingerprint dialog compete with external authenticators. Since
MakeCredential now always triggers the transport selection UI, we can
now undo this limitation if the UI is active.

Bug:  873710 
Change-Id: I68ad9f0e7d5c3bdeda84652f893dc5df2743254f
Reviewed-on: https://chromium-review.googlesource.com/1180541
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585639}
[modify] https://crrev.com/23355d599daab8e118873292d023c6db26f4b098/chrome/browser/webauthn/chrome_authenticator_request_delegate.cc
[modify] https://crrev.com/23355d599daab8e118873292d023c6db26f4b098/chrome/browser/webauthn/chrome_authenticator_request_delegate.h
[modify] https://crrev.com/23355d599daab8e118873292d023c6db26f4b098/content/browser/webauth/authenticator_impl_unittest.cc
[modify] https://crrev.com/23355d599daab8e118873292d023c6db26f4b098/content/public/browser/authenticator_request_client_delegate.cc
[modify] https://crrev.com/23355d599daab8e118873292d023c6db26f4b098/content/public/browser/authenticator_request_client_delegate.h
[modify] https://crrev.com/23355d599daab8e118873292d023c6db26f4b098/device/fido/fido_request_handler_base.cc
[modify] https://crrev.com/23355d599daab8e118873292d023c6db26f4b098/device/fido/fido_request_handler_base.h
[modify] https://crrev.com/23355d599daab8e118873292d023c6db26f4b098/device/fido/fido_request_handler_unittest.cc
[modify] https://crrev.com/23355d599daab8e118873292d023c6db26f4b098/device/fido/make_credential_handler_unittest.cc
[modify] https://crrev.com/23355d599daab8e118873292d023c6db26f4b098/device/fido/make_credential_request_handler.cc
[modify] https://crrev.com/23355d599daab8e118873292d023c6db26f4b098/device/fido/make_credential_request_handler.h

Comment 2 by martinkr@google.com, Aug 27

Status: Fixed (was: Assigned)
►

Sign in to add a comment