New issue
Advanced search Search tips

Issue 873707 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
diand...@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Gerrit appends commit message text on revert CLs that is wrong for Chrome OS

Project Member Reported by kirtika@chromium.org, Aug 13 
dianders@ first found the issue here: 
https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1171408/3

I created a test revert here: 
https://chromium-review.googlesource.com/c/aosp/platform/system/connectivity/shill/+/1172934

The appended text was:
<snip>
TBR=semenzato@chromium.org,benchan@chromium.org,kirtika@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:832145 
Change-Id: Ie9c745c6890232155e8649e6a98d5f343dc1a515
</snip>

This is wrong for Chrome OS in many ways: 
1. Chrome OS doesn't use TBR
2. It is "BUG=" not "BUG:"
We also have a "TEST=" right under the "BUG=" in our commit messages. 
3. Not sure why the "Not skipping CQ checks" line is needed. That seems
to be a chromium thing.

Comment 1 by ajp@chromium.org, Dec 4

Labels: -Pri-2 Pri-3
Yeah, I think this is all from the chromium-behavior plugin. 

"# Not skipping CQ checks because original CL landed > 1 day ago." is just explaining the bot behavior. If the CL is new enough it will skip CQ checks and just land the revert.

Seems like to fix this we'd either have to unify how ChromeOS & Browser handle commit footers (probably harder to do) or find a way to configure the plugin on a per-repo basis based on whether the repo is Chrome OS or Chrome Browser. I don't really love that but hopefully repos change infrequently enough that it would be manageable. 

For now we don't have staffing for a project like this so just marking it available as p3. But if this is a big deal for ChromeOS please let me know.

Comment 2 by ajp@chromium.org, Dec 4

Status: Available (was: Untriaged)
►

Sign in to add a comment