Refactor custom background "is customized?" logic for better testability |
||||
Issue descriptionCustomization is stored in a user pref, and saved in https://cs.chromium.org/chromium/src/chrome/browser/search/instant_service.cc?type=cs&q=kNtpCustomBackgroundURL&sq=package:chromium&g=0&l=49. It's hard to check for an active customization in unit tests, eg https://cs.chromium.org/chromium/src/chrome/browser/ui/search/ntp_user_data_logger_unittest.cc
,
Nov 9
,
Nov 15
,
Nov 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/427c8da475769e2cb56119f681f995ad3afdb182 commit 427c8da475769e2cb56119f681f995ad3afdb182 Author: Kyle Milka <kmilka@chromium.org> Date: Mon Nov 26 21:59:05 2018 [NTP] Add method to check if a custom background is set Add a method to InstantService to check if a custom background has been set. Clean up a few places that were checking the pref directly. Bug: 873699 Change-Id: I755c6d26cb5fc6cce1239fd796fbfc5e3fb45ce5 Reviewed-on: https://chromium-review.googlesource.com/c/1338091 Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#610955} [modify] https://crrev.com/427c8da475769e2cb56119f681f995ad3afdb182/chrome/browser/search/instant_service.cc [modify] https://crrev.com/427c8da475769e2cb56119f681f995ad3afdb182/chrome/browser/search/instant_service.h [modify] https://crrev.com/427c8da475769e2cb56119f681f995ad3afdb182/chrome/browser/search/instant_service_unittest.cc [modify] https://crrev.com/427c8da475769e2cb56119f681f995ad3afdb182/chrome/browser/ui/search/ntp_user_data_logger.cc
,
Nov 26
,
Nov 28
The NextAction date has arrived: 2018-11-28 |
||||
►
Sign in to add a comment |
||||
Comment 1 by kmilka@chromium.org
, Oct 16Owner: kmilka@chromium.org
Status: Started (was: Assigned)