New issue
Advanced search Search tips

Issue 873691 link

Starred by 0 users
Status: Fixed
Owner:
johnchen@chromium.org
Closed: Aug 14
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Merge request for ChromeDriver SetTimeouts command W3C compliance

Project Member Reported by johnchen@chromium.org, Aug 13 
Requesting merge of https://chromium-review.googlesource.com/1166212 to m69 branch. This CL fix ChromeDriver to make its SetTimeouts command compliant to W3C standard. The change was original done under  issue chromedriver:2057 .

Note that these changes are in ChromeDriver directory (src/chrome/test/chromedriver), and Chrome does not depend on that at all, so these will have no impact on Chrome binary that is shipping. See go/chromedriver-versioning and go/chops-proj-rev-27 for background.
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 13

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by gov...@chromium.org, Aug 13

Labels: -Merge-Review-69 Merge-Approved-69
Approving merge to M69 branch 3497 based on comment #0. Please merge ASAP.

Comment 3 by johnchen@chromium.org, Aug 14

Labels: merge-merged-3497
Status: Fixed (was: Assigned)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76b635d5a820b4d2a1e3fda790f5a144e5a49f5b

commit 76b635d5a820b4d2a1e3fda790f5a144e5a49f5b
Author: John Chen <johnchen@chromium.org>
Date: Mon Aug 13 20:49:37 2018

[ChromeDriver] W3C compliant SetTimeouts command

Update the SetTimeouts command to accept both pre-W3C and W3C format
parameters.

Bug:   chromedriver:2057  , 873691
Change-Id: Ib380b62fbd279812c62e04e6dc4ce214dc042343
Reviewed-on: https://chromium-review.googlesource.com/1166212
Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#581736}(cherry picked from commit ce49639fbef25e273bcc072154c7abed2894d052)
Reviewed-on: https://chromium-review.googlesource.com/1173080
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#589}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/76b635d5a820b4d2a1e3fda790f5a144e5a49f5b/chrome/test/chromedriver/client/chromedriver.py
[modify] https://crrev.com/76b635d5a820b4d2a1e3fda790f5a144e5a49f5b/chrome/test/chromedriver/client/command_executor.py
[modify] https://crrev.com/76b635d5a820b4d2a1e3fda790f5a144e5a49f5b/chrome/test/chromedriver/server/http_handler.cc
[modify] https://crrev.com/76b635d5a820b4d2a1e3fda790f5a144e5a49f5b/chrome/test/chromedriver/session_commands.cc
[modify] https://crrev.com/76b635d5a820b4d2a1e3fda790f5a144e5a49f5b/chrome/test/chromedriver/session_commands.h
[modify] https://crrev.com/76b635d5a820b4d2a1e3fda790f5a144e5a49f5b/chrome/test/chromedriver/session_commands_unittest.cc
[modify] https://crrev.com/76b635d5a820b4d2a1e3fda790f5a144e5a49f5b/chrome/test/chromedriver/test/run_py_tests.py

Comment 4 by gov...@chromium.org, Aug 14

Labels: -Merge-Approved-69
Already merged to M69 at #3.
►

Sign in to add a comment