Merge request fix ChromeDriver version in release branches |
|||||
Issue descriptionRequesting merge of two commits that fix the version displayed by ChromeDriver built in release branches. Previously, ChromeDriver from release branches uses the same version string (such as 2.41) as ChromeDriver built in master branch, making it difficult to identify the source of the build. These commits modify ChromeDriver to use the same version scheme as Chrome itself, and is part of the overall effort to match ChromeDriver releases with Chrome releases. The following two commits will be merged: * https://chromium-review.googlesource.com/1166229 * https://chromium-review.googlesource.com/1171843 Note that these changes are in ChromeDriver directory (src/chrome/test/chromedriver), and Chrome does not depend on that at all, so these will have no impact on Chrome binary that is shipping. See go/chromedriver-versioning and go/chops-proj-rev-27 for background.
,
Aug 13
Approving merge to M69 branch 3497 based on comment #0
,
Aug 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/175bd1a52fc9755ff60f5110e49e97644ed6299f commit 175bd1a52fc9755ff60f5110e49e97644ed6299f Author: John Chen <johnchen@chromium.org> Date: Mon Aug 13 20:51:59 2018 [ChromeDriver] Use Chrome version in release branches ChromeDriver built in Chrome release branches now embeds Chrome version number (e.g., 69.0.3497.23) instead of ChromeDriver version (e.g., 2.41). Bug: chromedriver:2080, 873688 Change-Id: I8727b0c42ad3d59a0833345a596a4bdbce83b282 Reviewed-on: https://chromium-review.googlesource.com/1166229 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#581945}(cherry picked from commit 2765df342b13ae96fdd937cf7195bd46da119c94) Reviewed-on: https://chromium-review.googlesource.com/1173083 Reviewed-by: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#591} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/175bd1a52fc9755ff60f5110e49e97644ed6299f/chrome/test/chromedriver/BUILD.gn [modify] https://crrev.com/175bd1a52fc9755ff60f5110e49e97644ed6299f/chrome/test/chromedriver/embed_version_in_cpp.py
,
Aug 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d9d404a2727d2ce75262cb7f3613ca795305ebf commit 3d9d404a2727d2ce75262cb7f3613ca795305ebf Author: John Chen <johnchen@chromium.org> Date: Mon Aug 13 20:53:17 2018 [ChromeDriver] Fix version string in release branch The previous change (r581945) to update version string used by ChromeDriver in release branches didn't work, because the top-most commit doesn't have the necessary branch info. This CL adds the same commit filter used to generate the version string shown by Chrome. Bug: chromedriver:2080, 873688 Change-Id: I4d7b57a139968d3e5e0f1ebad26d6ed648ab5d72 Reviewed-on: https://chromium-review.googlesource.com/1171843 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#582404}(cherry picked from commit dbe92472c755ab9519221b35a96c1458a61293cf) Reviewed-on: https://chromium-review.googlesource.com/1173135 Reviewed-by: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#592} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/3d9d404a2727d2ce75262cb7f3613ca795305ebf/chrome/test/chromedriver/embed_version_in_cpp.py
,
Aug 14
Already merged to M69 at #3 & #4. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sheriffbot@chromium.org
, Aug 13