New issue
Advanced search Search tips

Issue 873676 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug-Regression



Sign in to add a comment

AudioOutputTest.Play200HzTone flakes since media API update SDK roll

Project Member Reported by w...@chromium.org, Aug 13

Issue description

AudioOutputTest.Play200HzTone has been failing, only on the Fuchsia/x64/Debug bot, since https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-x64-dbg/1052 with a renderer-error crash:

#01: media::AudioOutputStreamFuchsia::OnRendererError() at ../../media/audio/fuchsia/audio_output_stream_fuchsia.cc:145
#02: operator() at ../../third_party/fuchsia-sdk/sdk/pkg/fit/include/lib/fit/function.h:178
#03: fit::internal::target<auto fit::bind_member<void, media::AudioOutputStreamFuchsia>(media::AudioOutputStreamFuchsia*, void (media::AudioOutputStreamFuchsia::*)())::{lambda()#1}, false, void>::invoke(void*) at ../../third_party/fuchsia-sdk/sdk/pkg/fit/include/lib/fit/function_internal.h:109
#04: fit::internal::function<16ul, false, void ()>::operator()() const at ../../third_party/fuchsia-sdk/sdk/pkg/fit/include/lib/fit/function_internal.h:182
#05: fidl::internal::MessageReader::NotifyError() at ./../../third_party/fuchsia-sdk/sdk/pkg/fidl_cpp/internal/message_reader.cc:?
#06: fidl::internal::MessageReader::OnHandleReady(async_dispatcher*, int, zx_packet_signal const*) at ./../../third_party/fuchsia-sdk/sdk/pkg/fidl_cpp/internal/message_reader.cc:?
#07: fidl::internal::MessageReader::CallHandler(async_dispatcher*, async_wait*, int, zx_packet_signal const*) at ../../third_party/fuchsia-sdk/sdk/pkg/fidl_cpp/internal/message_reader.cc:166
#08: base::AsyncDispatcher::DispatchOrWaitUntil(unsigned long) at ../../base/fuchsia/async_dispatcher.cc:153
#09: base::MessagePumpFuchsia::HandleEvents(unsigned long) at ../../base/message_loop/message_pump_fuchsia.cc:236
#10: base::MessagePumpFuchsia::Run(base::MessagePump::Delegate*) at ../../base/message_loop/message_pump_fuchsia.cc:256
#11: base::MessageLoop::Run(bool) at ./../../base/message_loop/message_loop.cc:?
#12: base::RunLoop::Run() at ../../base/run_loop.cc:105
#13: media::AudioOutputTest::RunMessageLoop(base::TimeDelta) at ../../media/audio/audio_output_unittest.cc:53
#14: media::AudioOutputTest_Play200HzTone_Test::TestBody() at ../../media/audio/audio_output_unittest.cc:115
#15: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::TestCase, void>(testing::TestCase*, void (testing::TestCase::*)(), char const*) at ../../third_party/googletest/src/googletest/src/gtest.cc:2432
#16: void testing::internal::HandleExceptionsInMethodIfSupported<testing::TestCase, void>(testing::TestCase*, void (testing::TestCase::*)(), char const*) at ../../third_party/googletest/src/googletest/src/gtest.cc:2487
#17: testing::Test::Run() at ../../third_party/googletest/src/googletest/src/gtest.cc:2513
#18: testing::TestInfo::Run() at ../../third_party/googletest/src/googletest/src/gtest.cc:2686
#19: testing::TestCase::Run() at ../../third_party/googletest/src/googletest/src/gtest.cc:2799
#20: testing::internal::UnitTestImpl::RunAllTests() at ../../third_party/googletest/src/googletest/src/gtest.cc:5123
#21: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) at ../../third_party/googletest/src/googletest/src/gtest.cc:2432
#22: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) at ../../third_party/googletest/src/googletest/src/gtest.cc:2487
#23: testing::UnitTest::Run() at ../../third_party/googletest/src/googletest/src/gtest.cc:4733
#24: RUN_ALL_TESTS() at ../../third_party/googletest/src/googletest/include/gtest/gtest.h:2331
#25: base::TestSuite::Run() at ../../base/test/test_suite.cc:277
#26: int base::internal::FunctorTraits<int (base::TestSuite::*)(), void>::Invoke<int (base::TestSuite::*)(), base::TestSuite*>(int (base::TestSuite::*)(), base::TestSuite*&&) at ../../base/bind_internal.h:516
#27: int base::internal::InvokeHelper<false, int>::MakeItSo<int (base::TestSuite::* const&)(), base::TestSuite*>(int (base::TestSuite::* const&)(), base::TestSuite*&&) at ../../base/bind_internal.h:616
#28: int base::internal::Invoker<base::internal::BindState<int (base::TestSuite::*)(), base::internal::UnretainedWrapper<base::TestSuite> >, int ()>::RunImpl<int (base::TestSuite::* const&)(), std::__2::tuple<base::internal::UnretainedWrapper<base::TestSuite> > const&, 0ul>(int (base::TestSuite::* const&)(), std::__2::tuple<base::internal::UnretainedWrapper<base::TestSuite> > const&, std::__2::integer_sequence<unsigned long, 0ul>) at ../../base/bind_internal.h:689
#29: base::internal::Invoker<base::internal::BindState<int (base::TestSuite::*)(), base::internal::UnretainedWrapper<base::TestSuite> >, int ()>::Run(base::internal::BindStateBase*) at ../../base/bind_internal.h:671
#30: base::OnceCallback<int ()>::Run() && at ../../base/callback.h:100
#31: base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) at ../../base/test/launcher/unit_test_launcher.cc:224
#32: base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) at ../../base/test/launcher/unit_test_launcher.cc:575
#33: main at ../../media/test/run_all_unittests.cc:55
#34: pc 0x58d7a53aad1f sp 0x2e1c1325dfe0 (libc.so,0x19d1f)
#35: pc 0 sp 0x2e1c1325e000

Not sure why this would regress on Debug but not Release.
 
Labels: -Pri-2 Pri-1
Owner: w...@chromium.org
Status: Started (was: Untriaged)
Summary: AudioOutputTest.Play200HzTone flakes since media API update SDK roll (was: AudioOutputTest.Play200HzTone fails since media API update SDK roll)
This test is actually flaking on Fuchsia/x64/Rel on the waterfall, so will need to be temporarily disabled pending a fix.

Given that it fails consistently on Fuchsia/x64/Debug, this is most likely a timing-dependent race in the test itself.
Cc: cmumford@chromium.org w...@chromium.org
 Issue 873694  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4111feb4fbe80f159b4a16e94ad9e1a35bd69bc7

commit 4111feb4fbe80f159b4a16e94ad9e1a35bd69bc7
Author: Wez <wez@chromium.org>
Date: Mon Aug 13 17:42:48 2018

Disable flaking AudioOutputTest.Play200HzTone test under Fuchsia.

Test started flaking on the waterfall following the latest SDK roll, so
disable it pending investigation.

TBR=maxmorin

Bug:  873676 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Idb17f16b8df8948e061b5abb63cae5ae32e04b89
Reviewed-on: https://chromium-review.googlesource.com/1172938
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582631}
[modify] https://crrev.com/4111feb4fbe80f159b4a16e94ad9e1a35bd69bc7/media/audio/audio_output_unittest.cc

Cc: sergeyu@chromium.org
Owner: sergeyu@chromium.org
Status: Assigned (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d123b36a9ba8f4b7b56175baf8acc173644f0a5

commit 5d123b36a9ba8f4b7b56175baf8acc173644f0a5
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Thu Aug 16 20:12:35 2018

[Fuchsia] Move chromium to AudioOut interface

AudioRenderer interface is being replaced with AudioOut. Updated
//media and //chromecast to use the new interface. Also fixed a crash
in FIDL interface handler.

Bug:  873676 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib0f9963fb7b39033bb89a0945a4b8eb5616594cc
Reviewed-on: https://chromium-review.googlesource.com/1175240
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583789}
[modify] https://crrev.com/5d123b36a9ba8f4b7b56175baf8acc173644f0a5/chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia.cc
[modify] https://crrev.com/5d123b36a9ba8f4b7b56175baf8acc173644f0a5/chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia.h
[modify] https://crrev.com/5d123b36a9ba8f4b7b56175baf8acc173644f0a5/media/audio/audio_output_unittest.cc
[modify] https://crrev.com/5d123b36a9ba8f4b7b56175baf8acc173644f0a5/media/audio/fuchsia/audio_output_stream_fuchsia.cc
[modify] https://crrev.com/5d123b36a9ba8f4b7b56175baf8acc173644f0a5/media/audio/fuchsia/audio_output_stream_fuchsia.h
[modify] https://crrev.com/5d123b36a9ba8f4b7b56175baf8acc173644f0a5/third_party/fuchsia-sdk/BUILD.gn

Status: Fixed (was: Assigned)

Sign in to add a comment