This should allow us to remove |origin_url| from FileSystemManager::Open.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2eeb21dd6bd45b9bb46039b00b8b7629a013698e commit 2eeb21dd6bd45b9bb46039b00b8b7629a013698e Author: Adithya Srinivasan <adithyas@chromium.org> Date: Tue Sep 25 17:25:27 2018 [FileSystem] Remove WebFileSystem - Adds blink.mojom.FileSystemManager to the frame and worker registries, allowing it to be accessed directly from ExecutionContext::GetInterfaceProvider()->GetInterface() - Changes ownership of blink::FileSystemDispatcher: now owned by ExecutionContext - Omits render_frame_id_ from ChooseEntry - Removes WebFileSystem and content::FileSystemDispatcher Bug: 787281, 873661 Change-Id: Ie41d48c5a206b5d1f387fcee3bd47bc30a708f0f Reviewed-on: https://chromium-review.googlesource.com/1217506 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#593983} [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/content/browser/fileapi/file_system_manager_impl.cc [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/content/browser/fileapi/file_system_manager_impl.h [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/content/browser/frame_host/render_frame_host_impl.h [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/content/browser/renderer_host/render_process_host_impl.h [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/content/browser/renderer_interface_binders.cc [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/content/renderer/BUILD.gn [delete] https://crrev.com/634d90a80671ad81200e7a3b973da2565b291c1f/content/renderer/fileapi/OWNERS [delete] https://crrev.com/634d90a80671ad81200e7a3b973da2565b291c1f/content/renderer/fileapi/file_system_dispatcher.cc [delete] https://crrev.com/634d90a80671ad81200e7a3b973da2565b291c1f/content/renderer/fileapi/file_system_dispatcher.h [delete] https://crrev.com/634d90a80671ad81200e7a3b973da2565b291c1f/content/renderer/fileapi/webfilesystem_impl.cc [delete] https://crrev.com/634d90a80671ad81200e7a3b973da2565b291c1f/content/renderer/fileapi/webfilesystem_impl.h [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/content/renderer/pepper/pepper_file_system_host.cc [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/content/renderer/render_thread_impl.cc [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/content/renderer/renderer_blink_platform_impl.h [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/third_party/blink/public/BUILD.gn [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/third_party/blink/public/mojom/filesystem/file_system.mojom [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/third_party/blink/public/platform/platform.h [delete] https://crrev.com/634d90a80671ad81200e7a3b973da2565b291c1f/third_party/blink/public/platform/web_file_system.h [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/third_party/blink/public/web/web_dom_file_system.h [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/third_party/blink/public/web/web_local_frame_client.h [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/third_party/blink/renderer/modules/filesystem/dom_file_system.cc [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/third_party/blink/renderer/modules/filesystem/dom_file_system_base.cc [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/third_party/blink/renderer/modules/filesystem/dom_file_system_base.h [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/third_party/blink/renderer/modules/filesystem/dom_file_system_sync.cc [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/third_party/blink/renderer/modules/filesystem/file_system_dispatcher.cc [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/third_party/blink/renderer/modules/filesystem/file_system_dispatcher.h [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/third_party/blink/renderer/modules/filesystem/file_system_file_handle.cc [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/third_party/blink/renderer/modules/filesystem/file_writer.cc [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/third_party/blink/renderer/modules/filesystem/file_writer_sync.cc [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/third_party/blink/renderer/modules/filesystem/file_writer_sync.h [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/third_party/blink/renderer/modules/filesystem/local_file_system.cc [modify] https://crrev.com/2eeb21dd6bd45b9bb46039b00b8b7629a013698e/third_party/blink/renderer/modules/filesystem/local_file_system.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7d1e30c1691f05a625c2f218579b350a3442381 commit e7d1e30c1691f05a625c2f218579b350a3442381 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Wed Sep 26 22:34:06 2018 Revert "[FileSystem] Remove WebFileSystem" This reverts commit 2eeb21dd6bd45b9bb46039b00b8b7629a013698e. Reason for revert: This CL is causing crashes in canary (https://crbug.com/889422) Original change's description: > [FileSystem] Remove WebFileSystem > > - Adds blink.mojom.FileSystemManager to the frame and worker > registries, allowing it to be accessed directly from > ExecutionContext::GetInterfaceProvider()->GetInterface() > - Changes ownership of blink::FileSystemDispatcher: now owned by > ExecutionContext > - Omits render_frame_id_ from ChooseEntry > - Removes WebFileSystem and content::FileSystemDispatcher > > Bug: 787281, 873661 > Change-Id: Ie41d48c5a206b5d1f387fcee3bd47bc30a708f0f > Reviewed-on: https://chromium-review.googlesource.com/1217506 > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593983} TBR=kinuko@chromium.org,mek@chromium.org,pwnall@chromium.org,adithyas@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 787281, 873661 Change-Id: Iacfc3c08d838f2258fd35603270d41beab086623 No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/1246863 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#594503} [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/content/browser/fileapi/file_system_manager_impl.cc [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/content/browser/fileapi/file_system_manager_impl.h [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/content/browser/frame_host/render_frame_host_impl.h [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/content/browser/renderer_host/render_process_host_impl.h [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/content/browser/renderer_interface_binders.cc [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/content/renderer/BUILD.gn [add] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/content/renderer/fileapi/OWNERS [add] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/content/renderer/fileapi/file_system_dispatcher.cc [add] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/content/renderer/fileapi/file_system_dispatcher.h [add] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/content/renderer/fileapi/webfilesystem_impl.cc [add] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/content/renderer/fileapi/webfilesystem_impl.h [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/content/renderer/pepper/pepper_file_system_host.cc [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/content/renderer/render_thread_impl.cc [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/content/renderer/renderer_blink_platform_impl.h [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/third_party/blink/public/BUILD.gn [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/third_party/blink/public/mojom/filesystem/file_system.mojom [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/third_party/blink/public/platform/platform.h [add] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/third_party/blink/public/platform/web_file_system.h [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/third_party/blink/public/web/web_dom_file_system.h [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/third_party/blink/public/web/web_local_frame_client.h [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/third_party/blink/renderer/modules/filesystem/dom_file_system.cc [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/third_party/blink/renderer/modules/filesystem/dom_file_system_base.cc [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/third_party/blink/renderer/modules/filesystem/dom_file_system_base.h [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/third_party/blink/renderer/modules/filesystem/dom_file_system_sync.cc [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/third_party/blink/renderer/modules/filesystem/file_system_dispatcher.cc [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/third_party/blink/renderer/modules/filesystem/file_system_dispatcher.h [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/third_party/blink/renderer/modules/filesystem/file_system_file_handle.cc [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/third_party/blink/renderer/modules/filesystem/file_writer.cc [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/third_party/blink/renderer/modules/filesystem/file_writer_sync.cc [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/third_party/blink/renderer/modules/filesystem/file_writer_sync.h [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/third_party/blink/renderer/modules/filesystem/local_file_system.cc [modify] https://crrev.com/e7d1e30c1691f05a625c2f218579b350a3442381/third_party/blink/renderer/modules/filesystem/local_file_system.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87907405436d5de2ac42ce47b5f63f7dc1c69ec5 commit 87907405436d5de2ac42ce47b5f63f7dc1c69ec5 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Fri Oct 05 15:12:39 2018 Reland "[FileSystem] Remove WebFileSystem" This is a reland of 2eeb21dd6bd45b9bb46039b00b8b7629a013698e Original change's description: > [FileSystem] Remove WebFileSystem > > - Adds blink.mojom.FileSystemManager to the frame and worker > registries, allowing it to be accessed directly from > ExecutionContext::GetInterfaceProvider()->GetInterface() > - Changes ownership of blink::FileSystemDispatcher: now owned by > ExecutionContext > - Omits render_frame_id_ from ChooseEntry > - Removes WebFileSystem and content::FileSystemDispatcher > > Bug: 787281, 873661 > Change-Id: Ie41d48c5a206b5d1f387fcee3bd47bc30a708f0f > Reviewed-on: https://chromium-review.googlesource.com/1217506 > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593983} Bug: 787281, 873661 Change-Id: Ic5d211e2102ebcfef12b51ad59c7eefc6373f5a6 Reviewed-on: https://chromium-review.googlesource.com/c/1258202 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#597127} [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/content/browser/fileapi/file_system_manager_impl.cc [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/content/browser/fileapi/file_system_manager_impl.h [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/content/browser/frame_host/render_frame_host_impl.h [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/content/browser/renderer_host/render_process_host_impl.h [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/content/browser/renderer_interface_binders.cc [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/content/renderer/BUILD.gn [delete] https://crrev.com/5e7ff6c303b15be77d2f3e0a062ef9c8f8cd4450/content/renderer/fileapi/OWNERS [delete] https://crrev.com/5e7ff6c303b15be77d2f3e0a062ef9c8f8cd4450/content/renderer/fileapi/file_system_dispatcher.cc [delete] https://crrev.com/5e7ff6c303b15be77d2f3e0a062ef9c8f8cd4450/content/renderer/fileapi/file_system_dispatcher.h [delete] https://crrev.com/5e7ff6c303b15be77d2f3e0a062ef9c8f8cd4450/content/renderer/fileapi/webfilesystem_impl.cc [delete] https://crrev.com/5e7ff6c303b15be77d2f3e0a062ef9c8f8cd4450/content/renderer/fileapi/webfilesystem_impl.h [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/content/renderer/pepper/pepper_file_system_host.cc [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/content/renderer/render_thread_impl.cc [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/content/renderer/renderer_blink_platform_impl.h [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/third_party/blink/public/BUILD.gn [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/third_party/blink/public/mojom/filesystem/file_system.mojom [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/third_party/blink/public/platform/platform.h [delete] https://crrev.com/5e7ff6c303b15be77d2f3e0a062ef9c8f8cd4450/third_party/blink/public/platform/web_file_system.h [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/third_party/blink/public/web/web_dom_file_system.h [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/third_party/blink/public/web/web_local_frame_client.h [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/third_party/blink/renderer/modules/filesystem/dom_file_system.cc [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/third_party/blink/renderer/modules/filesystem/dom_file_system_base.cc [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/third_party/blink/renderer/modules/filesystem/dom_file_system_base.h [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/third_party/blink/renderer/modules/filesystem/dom_file_system_sync.cc [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/third_party/blink/renderer/modules/filesystem/file_system_dispatcher.cc [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/third_party/blink/renderer/modules/filesystem/file_system_dispatcher.h [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/third_party/blink/renderer/modules/filesystem/file_system_file_handle.cc [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/third_party/blink/renderer/modules/filesystem/file_writer.cc [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/third_party/blink/renderer/modules/filesystem/file_writer_sync.cc [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/third_party/blink/renderer/modules/filesystem/file_writer_sync.h [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/third_party/blink/renderer/modules/filesystem/local_file_system.cc [modify] https://crrev.com/87907405436d5de2ac42ce47b5f63f7dc1c69ec5/third_party/blink/renderer/modules/filesystem/local_file_system.h
Comment 1 by adithyas@chromium.org
, Aug 14Labels: -Type-Bug Type-Task