New issue
Advanced search Search tips

Issue 873660 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 15
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[iOS][Test-Flaky] LinkOfTextWithCalloutOverride is flaky on iOS 11

Project Member Reported by javierrobles@chromium.org, Aug 13

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/335bd11f8608c9e5f2ca86d7ade7e3feca476f5e

commit 335bd11f8608c9e5f2ca86d7ade7e3feca476f5e
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Mon Aug 13 15:37:08 2018

[iOS][Test-Flaky] Mark flaky tests on iOS 11

Marks LinkOfTextWithCalloutNone and LinkOfTextWithCalloutOverride as
flaky.

Bug:  873662 , 873660 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8a5b70864ad3a6436e64211b1df868d4c673e75e

TBR: eugenebut@chromium.org
Change-Id: I8a5b70864ad3a6436e64211b1df868d4c673e75e
Reviewed-on: https://chromium-review.googlesource.com/1172684
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582587}
[modify] https://crrev.com/335bd11f8608c9e5f2ca86d7ade7e3feca476f5e/ios/web/web_state/js/context_menu_js_unittest.mm

Cc: kkhorimoto@chromium.org eugene...@chromium.org
Components: Mobile>WebView>Glue
Labels: -Pri-3 Pri-2 Type-Bug-Regression
Owner: michaeldo@chromium.org
Status: Assigned (was: Unconfirmed)
Is this new?
This is the test only for the old Context Menu implementation, which I am in the process of removing as we enable the new implementation for 100% of users.

This simulator flake may be new, but many context menu tests are unfortunately flaky, on device at least. I will try to improve them all now that old implementation will be removed.

(I will reference this bug and update status along with that CL.)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc2dbcbd92622f8803f5cb617802f1bcff6e6f4f

commit dc2dbcbd92622f8803f5cb617802f1bcff6e6f4f
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Tue Aug 14 22:13:08 2018

Enable post message context menu and remove flag.

This fully enables support for context menu in iFrames.

Bug:  873660 ,  873662 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3345f56f6812ef619c6ed5b7bcabd34e09de410f
Reviewed-on: https://chromium-review.googlesource.com/1174052
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583053}
[modify] https://crrev.com/dc2dbcbd92622f8803f5cb617802f1bcff6e6f4f/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/dc2dbcbd92622f8803f5cb617802f1bcff6e6f4f/ios/chrome/browser/context_menu/context_menu_egtest.mm
[modify] https://crrev.com/dc2dbcbd92622f8803f5cb617802f1bcff6e6f4f/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/dc2dbcbd92622f8803f5cb617802f1bcff6e6f4f/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/dc2dbcbd92622f8803f5cb617802f1bcff6e6f4f/ios/web/features.mm
[modify] https://crrev.com/dc2dbcbd92622f8803f5cb617802f1bcff6e6f4f/ios/web/public/features.h
[modify] https://crrev.com/dc2dbcbd92622f8803f5cb617802f1bcff6e6f4f/ios/web/web_state/context_menu_constants.h
[modify] https://crrev.com/dc2dbcbd92622f8803f5cb617802f1bcff6e6f4f/ios/web/web_state/js/context_menu_js_unittest.mm
[modify] https://crrev.com/dc2dbcbd92622f8803f5cb617802f1bcff6e6f4f/ios/web/web_state/js/resources/all_frames_context_menu.js
[modify] https://crrev.com/dc2dbcbd92622f8803f5cb617802f1bcff6e6f4f/ios/web/web_state/js/resources/main_frame_context_menu.js
[modify] https://crrev.com/dc2dbcbd92622f8803f5cb617802f1bcff6e6f4f/ios/web/web_state/ui/crw_context_menu_controller.mm

Status: WontFix (was: Assigned)
This test was removed. The equivalent test for the new Context Menu implementation is still in place and enabled: ContextMenuJsFindElementAtPointTest. LinkOfTextWithCalloutOverride

Sign in to add a comment