New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 873651 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Uprev deqp to a version with vulkan-cts 1.1

Project Member Reported by basni@chromium.org, Aug 13

Issue description

The current deqp version used for chromeos does not support vulkan 1.1, we need to fix this before we can expose vulkan 1.1 (except for Android).

https://bugs.chromium.org/p/chromium/issues/detail?id=845272 upreved it to android-p-preview-5, but it does not contain vulkan-cts-1.1, while master and pie-cts-dev do (and pie-cts-dev has had it for a while).

Not sure how accurate these previews really are supposed to be ...

android-p-preview-5: https://android.googlesource.com/platform/external/deqp/+log/e98bb687e85fb0e4b671f8e301a2f8ddee14f181

master:
https://android.googlesource.com/platform/external/deqp/+log/master

 
I can look into doing another uprev later today.  The last one (at the time that was tot) was done to fix some platform failures, without consideration to vulcan status. 
The uprev did not go smoothly.  I am getting a build error related to vulkancts: 

...
../framework/platform/surfaceless/tcuSurfacelessPlatform.cpp:113:14: error: allocating an object of abstract class type 'tcu::surfaceless::VulkanLibrary'
                return new VulkanLibrary();
                           ^
../external/vulkancts/framework/vulkan/vkPlatform.hpp:45:38: note: unimplemented pure virtual method 'getFunctionLibrary' in 'VulkanLibrary'
        virtual const tcu::FunctionLibrary&     getFunctionLibrary              (void) const = 0;

I'll keep working on it.

This is a legit error in the tcuSurfacelessPlatform.cpp definition of VulkanLibrary.   The fix (AFAIK) needs to be upstreamed before we can uprev deqp.
Fix is in deqp/master.  Uprev should be out for review today.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/68a997182f2161863af9f31f67ae9066e2357004

commit 68a997182f2161863af9f31f67ae9066e2357004
Author: Joe M. Kniss <djmk@google.com>
Date: Thu Aug 23 19:09:22 2018

media-gfx/deqp: uprev deqp for new vulkan cts

Uprev deqp to TOT, also updates associated tools (glslang, SPIRV...)

BUG= chromium:873651 
TEST=emerge-chell deqp, emerge-nyan deqp

Change-Id: I84d08841a09e5c07305cdc7df77409dd70bb4857
Reviewed-on: https://chromium-review.googlesource.com/1176297
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Joe Kniss <djmk@google.com>
Reviewed-by: Chad Versace <chadversary@chromium.org>
Reviewed-by: Joe Kniss <djmk@google.com>

[modify] https://crrev.com/68a997182f2161863af9f31f67ae9066e2357004/media-gfx/deqp/Manifest
[rename] https://crrev.com/68a997182f2161863af9f31f67ae9066e2357004/media-gfx/deqp/deqp-2018.08.15-r1.ebuild

Status: Fixed (was: Untriaged)
Status: Verified (was: Fixed)
Thanks, looks great!
Owner: djmk@chromium.org

Sign in to add a comment