Agreed, the "To turn this on" part is super misleading. I guess it refers to the part of the UI that's greyed out, but that is not very helpful.

Signin folks: Do you know who to assign this to? Who's responsible for this UI?

Issue 877406 has been merged into this issue.

The relevant code is passphraseResetHint:
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/people_page/sync_page.html?rcl=7d29353051d68181a880d0dc9129950da12a99c8&l=459

Which is mapped to IDS_SETTINGS_PASSPHRASE_RESET_HINT_UNIFIED_CONSENT:
https://cs.chromium.org/chromium/src/chrome/app/settings_strings.grdp?type=cs&q=IDS_SETTINGS_PASSPHRASE_RESET_HINT_UNIFIED_CONSENT

This seems to be a regression introduced with the UnifiedConsent revamp.
Before the revamp it was saying:
To change this setting, ...
Instead of:
To turn this on, ...

Correct, this does seem like a regression. It would be great if we could change it back (just for the "Encryption options" section, but keeping the note underneath "Activity and interactions" as "To turn this on...")

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d30bc83490e3fad014f50e37d650a67644fc7d93

commit d30bc83490e3fad014f50e37d650a67644fc7d93
Author: David Roger <droger@chromium.org>
Date: Thu Sep 06 12:46:38 2018

[settings] Fix layout and text for the passhprase reset hints

Bug: 873739,  873644 
Change-Id: I02e0819130678a1398106f0d0faf8068456e28dc
Reviewed-on: https://chromium-review.googlesource.com/1196451
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589142}
[modify] https://crrev.com/d30bc83490e3fad014f50e37d650a67644fc7d93/chrome/app/settings_strings.grdp
[modify] https://crrev.com/d30bc83490e3fad014f50e37d650a67644fc7d93/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/d30bc83490e3fad014f50e37d650a67644fc7d93/chrome/browser/resources/settings/people_page/sync_page.js
[modify] https://crrev.com/d30bc83490e3fad014f50e37d650a67644fc7d93/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/d30bc83490e3fad014f50e37d650a67644fc7d93/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Verified the fix on Mac 10.13.6, Windows 10 and Ubuntu 14.04 using Chrome version #71.0.3545.0 
Attaching screenshot for reference.
Observed that  " ⓘ To turn this on, reset sync to remove your sync passphrase" is removed
The fix is working as expected, adding Verified labels

Thanks...!

Deleted: 873644.png 30.0 KB

	873644.png 30.0 KB View Download

Is that the intention though? It seemed that we were going to reword rather than remove that text.

In the screenshot from c#9, the extra text isn't there because you haven't turned on the custom passphrase. You have to first opt into having a custom passphrase for your account (by clicking the other radio button), then you'll see it.

I confirmed on Canary that this is WAI: https://screenshot.googleplex.com/V9e6ySSnkzp.png. David is already reviewing the merge for the CL in another bug. Marking this as Fixed.

Ah. Got it.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74af165ee25554692657c7bf9c870b391e9d3b6d

commit 74af165ee25554692657c7bf9c870b391e9d3b6d
Author: David Roger <droger@chromium.org>
Date: Mon Sep 17 11:36:19 2018

[settings] Fix layout and text for the passhprase reset hints

TBR=droger@chromium.org

(cherry picked from commit d30bc83490e3fad014f50e37d650a67644fc7d93)

Bug: 873739,  873644 
Change-Id: I02e0819130678a1398106f0d0faf8068456e28dc
Reviewed-on: https://chromium-review.googlesource.com/1196451
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589142}
Reviewed-on: https://chromium-review.googlesource.com/1227941
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#442}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/74af165ee25554692657c7bf9c870b391e9d3b6d/chrome/app/settings_strings.grdp
[modify] https://crrev.com/74af165ee25554692657c7bf9c870b391e9d3b6d/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/74af165ee25554692657c7bf9c870b391e9d3b6d/chrome/browser/resources/settings/people_page/sync_page.js
[modify] https://crrev.com/74af165ee25554692657c7bf9c870b391e9d3b6d/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/74af165ee25554692657c7bf9c870b391e9d3b6d/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Note: the merge approval was on bug 873739, which was fixed by the same CL

Able to reproduce the issue on chrome version 70.0.3521.0 (build without fix) as per the comment #0.
Verified the fix on Mac 10.13.6, Windows 10 and Ubuntu 14.04 using Chrome version # 70.0.3538.22.
Attaching screenshot for reference.
Observed that "Removed the sync passphrase achieves the opposite of turning on encryption " 
The fix is working as expected, adding Verified labels

Thanks...!

Deleted: 873644.png 59.2 KB

	873644.png 59.2 KB View Download