New issue
Advanced search Search tips

Issue 873633 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

[iOS][Test-Disabled] TabGridMediatorTest.UndoCloseAllItemsCommand failing on devices

Project Member Reported by javierrobles@chromium.org, Aug 13

Issue description

Labels: OS-iOS
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1eaee79e7b9187f59541ebb4a02bedc799fb6edf

commit 1eaee79e7b9187f59541ebb4a02bedc799fb6edf
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Mon Aug 13 14:24:48 2018

[iOS][Test-Disabled] UndoCloseAllItemsCommand

Test is failing on non tablet iOS 10 devices and it is flaky on all iOS 11 ones.

Bug:  873633 , 873632 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie95325a3256021a401c3f8055d5e71f6dc40a590
Reviewed-on: https://chromium-review.googlesource.com/1172358
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582575}
[modify] https://crrev.com/1eaee79e7b9187f59541ebb4a02bedc799fb6edf/ios/chrome/browser/ui/tab_grid/tab_grid_mediator_unittest.mm

Cc: kariahda@chromium.org marq@chromium.org
Labels: -Pri-3 Pri-2
Owner: edchin@chromium.org
Status: Assigned (was: Untriaged)
Since the mentioned CL has been cherrypicked to M69 branch, we need to investigate further to see what's the proper next step.
Components: UI>Browser>Mobile>TabSwitcher
Will take a look.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a24c6d4802c9b55f877d97276e27a5f87edde5ba

commit a24c6d4802c9b55f877d97276e27a5f87edde5ba
Author: edchin <edchin@chromium.org>
Date: Tue Aug 14 23:28:11 2018

[ios] Disable flaky TabGridMediator tests

Previously we thought this was only flaky on devices. It is also flaky
on simulator.

TBR=justincohen, javierrobles

Bug:  873633 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iddc823fc1034ba26db75da1b42a63a864e58878a
Reviewed-on: https://chromium-review.googlesource.com/1175194
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583078}
[modify] https://crrev.com/a24c6d4802c9b55f877d97276e27a5f87edde5ba/ios/chrome/browser/ui/tab_grid/tab_grid_mediator_unittest.mm

Labels: -ReleaseBlock-Stable
Removed RBS. 
Labels: -M-69 ReleaseBlock-Beta M-70
Hi Ed, is there an update here? Per the below doc, we need to ensure this is not a product issue. Marking this RBB for M70.

https://docs.google.com/document/d/11HC2PlIr4Gmv7ABi89g-7tWov9lZNj7KxGTjgdyXYAU/edit#heading=h.kna5wflnhlys
Status: Started (was: Assigned)
CL is in-flight.
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02d31f92255758524360faea590467f9bec56a58

commit 02d31f92255758524360faea590467f9bec56a58
Author: edchin <edchin@chromium.org>
Date: Thu Aug 16 12:09:44 2018

[ios] Pass in dependency into TabGridMediator

This CL fixes the failing TabGridMediator unittests.
The TabRestoreService is a dependency that is needed
in the TabGridMediator, but that requires a valid
browserState.
This CL properly passes in the TabRestoreService
dependency, instead of allowing the TabGridMediator
to grab it using the browserState.

Other dependencies should also be passed in, but
this CL is intentionally kept small.

Bug:  873632 ,  873633 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie262f283b35c5a8cf5299d00e0a8cf680628cf53
Reviewed-on: https://chromium-review.googlesource.com/1176966
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583607}
[modify] https://crrev.com/02d31f92255758524360faea590467f9bec56a58/ios/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm
[modify] https://crrev.com/02d31f92255758524360faea590467f9bec56a58/ios/chrome/browser/ui/tab_grid/tab_grid_mediator.h
[modify] https://crrev.com/02d31f92255758524360faea590467f9bec56a58/ios/chrome/browser/ui/tab_grid/tab_grid_mediator.mm
[modify] https://crrev.com/02d31f92255758524360faea590467f9bec56a58/ios/chrome/browser/ui/tab_grid/tab_grid_mediator_unittest.mm

Status: Fixed (was: Started)

Sign in to add a comment