Issue metadata
Sign in to add a comment
|
[iOS][Test-Disabled] TabGridMediatorTest.UndoCloseAllItemsCommand failing on devices |
||||||||||||||||||||||
Issue descriptionhttps://chromium-review.googlesource.com/c/chromium/src/+/1167118 introduced a failing test only on devices, since the CL is around 5 days old and it was cherrypicked, it is late to revert it. Examples of failing runs: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone10-device-x64/builds/13526 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone10-device-x64/builds/13522 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone11-device-x64/builds/5983
,
Aug 13
,
Aug 13
,
Aug 14
Apparently it is also failing on simulator. So disabling altogether.
,
Aug 16
https://chromium-review.googlesource.com/c/chromium/src/+/1176966 CL in-flight.
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02d31f92255758524360faea590467f9bec56a58 commit 02d31f92255758524360faea590467f9bec56a58 Author: edchin <edchin@chromium.org> Date: Thu Aug 16 12:09:44 2018 [ios] Pass in dependency into TabGridMediator This CL fixes the failing TabGridMediator unittests. The TabRestoreService is a dependency that is needed in the TabGridMediator, but that requires a valid browserState. This CL properly passes in the TabRestoreService dependency, instead of allowing the TabGridMediator to grab it using the browserState. Other dependencies should also be passed in, but this CL is intentionally kept small. Bug: 873632 , 873633 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie262f283b35c5a8cf5299d00e0a8cf680628cf53 Reviewed-on: https://chromium-review.googlesource.com/1176966 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#583607} [modify] https://crrev.com/02d31f92255758524360faea590467f9bec56a58/ios/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm [modify] https://crrev.com/02d31f92255758524360faea590467f9bec56a58/ios/chrome/browser/ui/tab_grid/tab_grid_mediator.h [modify] https://crrev.com/02d31f92255758524360faea590467f9bec56a58/ios/chrome/browser/ui/tab_grid/tab_grid_mediator.mm [modify] https://crrev.com/02d31f92255758524360faea590467f9bec56a58/ios/chrome/browser/ui/tab_grid/tab_grid_mediator_unittest.mm
,
Aug 16
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Aug 13