https://wicg.github.io/background-fetch/#backgroundfetchregistration
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e commit e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e Author: Mugdha Lakhani <nator@chromium.org> Date: Wed Aug 15 13:34:19 2018 Background Fetch: Implement BackgroundFetchState Implement BackgroundFetch State for BackgroundFetchRegistration. Bug: 873630 Change-Id: I121f3bf55ea51bfa9b529175ccd5de951156ead9 Reviewed-on: https://chromium-review.googlesource.com/1172783 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#583233} [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/content/browser/background_fetch/background_fetch_context.cc [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/content/browser/background_fetch/background_fetch_context.h [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.cc [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.h [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/content/browser/background_fetch/background_fetch_event_dispatcher.cc [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/content/browser/background_fetch/background_fetch_event_dispatcher.h [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/content/browser/service_worker/embedded_worker_test_helper.h [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/content/common/service_worker/service_worker.mojom [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/content/renderer/service_worker/service_worker_context_client_unittest.cc [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/content/renderer/service_worker/service_worker_type_converters.cc [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/content/renderer/service_worker/service_worker_type_converters.h [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/third_party/WebKit/LayoutTests/external/wpt/background-fetch/idlharness.https.any-expected.txt [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/third_party/WebKit/LayoutTests/external/wpt/background-fetch/idlharness.https.any.sharedworker-expected.txt [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/third_party/WebKit/LayoutTests/external/wpt/background-fetch/idlharness.https.any.worker-expected.txt [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/third_party/blink/public/platform/modules/background_fetch/background_fetch.mojom [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/third_party/blink/public/web/modules/service_worker/web_service_worker_context_proxy.h [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.h [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.idl [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/third_party/blink/renderer/modules/background_fetch/background_fetch_type_converters.cc [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc [modify] https://crrev.com/e66f112c78e037dcdfd9d8bcd39c26fc6f1a8b5e/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c002010f128fb82e0cf9f90332125129dcaa3d35 commit c002010f128fb82e0cf9f90332125129dcaa3d35 Author: Mugdha Lakhani <nator@chromium.org> Date: Thu Aug 23 14:00:40 2018 Background Fetch: Propagate BackgroundFetchRegistration through various Background Fetch events. This also makes adding FailureReason to BackgroundFetchRegistration easy, since the plumbing to various service worker dispatcher classes won't have to be done again. Bug: 874092 , 873630 Change-Id: I1ae3b2115b1b1c357efa67e3e684423e5f4cd060 Reviewed-on: https://chromium-review.googlesource.com/1176085 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#585474} [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch.proto [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_context.cc [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_context.h [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.cc [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.h [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_event_dispatcher.cc [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_event_dispatcher.h [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_job_controller.cc [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_job_controller.h [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_test_base.cc [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_test_base.h [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/storage/create_metadata_task.cc [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/storage/database_helpers.cc [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/service_worker/embedded_worker_test_helper.h [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/common/background_fetch/background_fetch_struct_traits.cc [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/common/background_fetch/background_fetch_struct_traits.h [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/common/background_fetch/background_fetch_struct_traits_unittest.cc [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/common/background_fetch/background_fetch_types.cc [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/common/background_fetch/background_fetch_types.h [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/common/service_worker/service_worker.mojom [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/renderer/service_worker/service_worker_context_client_unittest.cc [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/third_party/blink/public/BUILD.gn [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/third_party/blink/public/platform/modules/background_fetch/background_fetch.mojom [add] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/third_party/blink/public/platform/modules/background_fetch/web_background_fetch_registration.h [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/third_party/blink/public/web/modules/service_worker/web_service_worker_context_proxy.h [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/third_party/blink/renderer/modules/background_fetch/background_fetch_bridge.cc [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.h [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/third_party/blink/renderer/modules/background_fetch/background_fetch_type_converters.cc [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc [modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/892b90f7a6b6d7e0494bd639d87dea3096738c5e commit 892b90f7a6b6d7e0494bd639d87dea3096738c5e Author: Mugdha Lakhani <nator@chromium.org> Date: Tue Sep 11 18:01:51 2018 [Background Fetch] Implement BackgroundFetchResult to align the implementation with the spec. https://wicg.github.io/background-fetch/#enumdef-backgroundfetchresult This change also gets rid of BackgroundFetchState. Bug: 881871 , 873630 Change-Id: I2be6087fdb68a4463872013b834611727ff525e6 Reviewed-on: https://chromium-review.googlesource.com/1213508 Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#590395} [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/content/browser/background_fetch/background_fetch.proto [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/content/browser/background_fetch/background_fetch_context.cc [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/content/browser/background_fetch/background_fetch_context.h [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/content/browser/background_fetch/background_fetch_job_controller.cc [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/content/browser/background_fetch/background_fetch_job_controller.h [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/content/browser/background_fetch/background_fetch_test_base.cc [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/content/browser/background_fetch/background_fetch_test_base.h [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/content/browser/background_fetch/storage/create_metadata_task.cc [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/content/browser/background_fetch/storage/database_helpers.cc [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/content/common/background_fetch/background_fetch_struct_traits.cc [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/content/common/background_fetch/background_fetch_struct_traits.h [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/content/common/background_fetch/background_fetch_struct_traits_unittest.cc [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/content/common/background_fetch/background_fetch_types.cc [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/content/common/background_fetch/background_fetch_types.h [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/third_party/WebKit/LayoutTests/external/wpt/background-fetch/fetch.https.window.js [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/third_party/WebKit/LayoutTests/external/wpt/background-fetch/get.https.window.js [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/third_party/WebKit/LayoutTests/external/wpt/background-fetch/idlharness.https.any-expected.txt [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/third_party/WebKit/LayoutTests/external/wpt/background-fetch/idlharness.https.any.serviceworker-expected.txt [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/third_party/WebKit/LayoutTests/external/wpt/background-fetch/idlharness.https.any.sharedworker-expected.txt [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/third_party/WebKit/LayoutTests/external/wpt/background-fetch/idlharness.https.any.worker-expected.txt [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/third_party/blink/public/platform/modules/background_fetch/background_fetch.mojom [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/third_party/blink/public/platform/modules/background_fetch/web_background_fetch_registration.h [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/third_party/blink/renderer/modules/background_fetch/background_fetch_bridge.cc [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.h [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.idl [modify] https://crrev.com/892b90f7a6b6d7e0494bd639d87dea3096738c5e/third_party/blink/renderer/modules/background_fetch/background_fetch_type_converters.cc
Comment 1 by bugdroid1@chromium.org
, Aug 15