New issue
Advanced search Search tips

Issue 873594 link

Starred by 1 user
Status: Fixed
Owner:
wzang@chromium.org
Closed: Aug 15
Cc:
ajha@chromium.org
alemate@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Virtual keyboard icon is not visible in OOBE

Project Member Reported by kebalaji@chromium.org, Aug 13 
Chrome Version: 70.0.3519.3/10964.0.0 dev channel Daisy,Reks,Candy
OS: Chrome OS

What steps will reproduce the problem?
(1)Recover build>> In OOBE, Enable On-screen keyboard and observe

Actual: The icon is not visible properly
Expected: Keyboard icon should be visible

This is a Regression issue as same is working fine in M69

@jdufault: Please confirm the issue
ActualVKIcon.jpg
4.1 MB View Download

Comment 1 by jdufault@chromium.org, Aug 14

Cc: jdufault@chromium.org
Labels: -M-70 M-69
Owner: wzang@chromium.org
wzang@ can you take a look? This should be a continuation of https://chromium-review.googlesource.com/c/chromium/src/+/1173056 and needs to be merged to 69
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fac86d9b8bf022181b1b68b6b05e0fe56c026b9

commit 3fac86d9b8bf022181b1b68b6b05e0fe56c026b9
Author: Wenzhao Zang <wzang@chromium.org>
Date: Wed Aug 15 06:17:46 2018

cros: Change virtual keyboard icon color in OOBE

This is a follow up for  crbug.com/857221 

Bug:  873594 
Change-Id: I8a5ab4fd2762b48b0b1fdd3d2f9d499673658d6d
Reviewed-on: https://chromium-review.googlesource.com/1175145
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583177}
[modify] https://crrev.com/3fac86d9b8bf022181b1b68b6b05e0fe56c026b9/ash/system/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/3fac86d9b8bf022181b1b68b6b05e0fe56c026b9/ash/system/virtual_keyboard/virtual_keyboard_tray.h

Comment 3 by wzang@chromium.org, Aug 15

Labels: Merge-Request-69
Merge request for CL in #2. It's a follow-up to  crbug.com/857221  which was already merged to M69.

Comment 4 by cindyb@chromium.org, Aug 15

Labels: -Merge-Request-69 Merge-Approved-69
Merge approved, M69.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 15

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58d5af9b44ccfe6f854f78adc2efba299eb87b7f

commit 58d5af9b44ccfe6f854f78adc2efba299eb87b7f
Author: Wenzhao Zang <wzang@chromium.org>
Date: Wed Aug 15 22:10:01 2018

[Merge to M69] cros: Change virtual keyboard icon color in OOBE

This is a follow up for  crbug.com/857221 

TBR=wzang@chromium.org

(cherry picked from commit 3fac86d9b8bf022181b1b68b6b05e0fe56c026b9)

Bug:  873594 
Change-Id: I8a5ab4fd2762b48b0b1fdd3d2f9d499673658d6d
Reviewed-on: https://chromium-review.googlesource.com/1175145
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#583177}
Reviewed-on: https://chromium-review.googlesource.com/1176469
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#661}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/58d5af9b44ccfe6f854f78adc2efba299eb87b7f/ash/system/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/58d5af9b44ccfe6f854f78adc2efba299eb87b7f/ash/system/virtual_keyboard/virtual_keyboard_tray.h

Comment 6 by wzang@chromium.org, Aug 15

Status: Fixed (was: Assigned)
►

Sign in to add a comment