New issue
Advanced search Search tips

Issue 873552 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

octopus/lakitu-relase failing in SignerTest.

Project Member Reported by llozano@chromium.org, Aug 13

Issue description

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8938587094219946080

Failure started on August 10 builder. And has been failing the same way since then.

Same thing with lakitu-gpu-release.

Not sure what component to use. 
So, using CI for guidance.

cc'ing sheriffs.
 
Summary: octopus/lakitu-relase failing in SignerTest. (was: lakitu-relase failing in SignerTest.)
Cc: jclinton@chromium.org vapier@chromium.org
Owner: moragues@chromium.org
It appears that the ensure_sane_lsb-release.sh lsb_synctaxcheck() is flagging the long lines genertated by the octopus unibuild.
we can increase the length for now
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/661cca6bf64a92a8a4d72196c0b69e0da7a423b5

commit 661cca6bf64a92a8a4d72196c0b69e0da7a423b5
Author: Bob Moragues <moragues@google.com>
Date: Tue Aug 14 04:58:48 2018

vboot: remove line length check from lsb_syntaxcheck()

Unibuilds, such as Octopus, generate long lines listing the
individual board names.

Removing a check which is restricting the unibuilds ability to add
additional boards to the list.

BUG= chromium:873552 
BRANCH=none
TEST=none

Change-Id: I080f4f251935eb19ee3377556500a5bd98117a2f
Reviewed-on: https://chromium-review.googlesource.com/1173256
Commit-Ready: Bob Moragues <moragues@chromium.org>
Tested-by: Bob Moragues <moragues@chromium.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>

[modify] https://crrev.com/661cca6bf64a92a8a4d72196c0b69e0da7a423b5/scripts/image_signing/ensure_sane_lsb-release.sh

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/cros-signing/+/0a257c18538440fe70084ad1432d9c717b6047da

commit 0a257c18538440fe70084ad1432d9c717b6047da
Author: Bob Moragues <moragues@google.com>
Date: Wed Aug 15 04:03:51 2018

Thanks Bob. SignerTest now passes for Octopus (10971.0.0). Lakitu-release is still failing but I don't think that's the same problem.
Status: Fixed (was: Untriaged)

Sign in to add a comment