New issue
Advanced search Search tips

Issue 873540 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

external/wpt/budget-api/idlharness.https.any.html fails on debug builds

Project Member Reported by shimazu@chromium.org, Aug 13

Issue description

It's failing on win7 dbg.

Failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/70842

Flakiness dashboard
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fbudget-api%2Fidlharness.https.any.html

The test is failing due to DCHECK in ScriptPromiseResolver.

== Stack trace ==

[4932:4356:0812/131917.804:ERROR:budget_service.cc(145)] Unable to connect to the Mojo BudgetService.
[4932:4356:0812/131926.913:FATAL:script_promise_resolver.h(57)] Check failed: state_ == kDetached || !is_promise_called_ || !GetScriptState()->ContextIsValid() || !GetExecutionContext() || GetExecutionContext()->IsContextDestroyed(). 
Backtrace:
	base::debug::StackTrace::StackTrace [0x6F58A9F6+102]
	base::debug::StackTrace::StackTrace [0x6F589A9B+27]
	logging::LogMessage::~LogMessage [0x6F5EF704+148]
	blink::ScriptPromiseResolver::~ScriptPromiseResolver [0x588771A8+280]
	blink::ScriptPromiseResolver::`scalar deleting destructor' [0x58883465+37]
	blink::GarbageCollectedFinalized<blink::ScriptPromiseResolver>::FinalizeGarbageCollectedObject [0x588A53FB+43]
	blink::FinalizerTraitImpl<blink::ScriptPromiseResolver,1>::Finalize [0x588A53C5+21]
	blink::FinalizerTrait<blink::ScriptPromiseResolver>::Finalize [0x588A5387+23]
	blink::HeapObjectHeader::Finalize [0x5715908B+107]
	blink::NormalPage::Sweep [0x5715F9D3+755]
	blink::BaseArena::SweepUnsweptPage [0x5715A23F+31]
	blink::BaseArena::CompleteSweep [0x5715A860+544]
	blink::ThreadState::EagerSweep [0x5717283E+446]
	blink::ThreadState::AtomicPauseEpilogue [0x5717228C+668]
	blink::ThreadState::RunAtomicPause [0x57177B84+548]
	blink::ThreadState::CollectGarbage [0x5716B4BA+954]
	blink::V8GCController::GcEpilogue [0x5899CCF8+1768]
	v8::internal::Heap::CallGCEpilogueCallbacks [0x5C81CE4F+415]
	v8::internal::Heap::PerformGarbageCollection [0x5C817E6E+3310]
	v8::internal::Heap::CollectGarbage [0x5C815807+1159]
	v8::internal::Heap::FinalizeIncrementalMarkingIfComplete [0x5C82252D+365]
	v8::internal::IncrementalMarkingJob::Task::RunInternal [0x5C84FE36+310]
	??$Invoke@P8Task@v8@@AEXXZV?$unique_ptr@VTask@v8@@U?$default_delete@VTask@v8@@@std@@@std@@$$V@?$FunctorTraits@P8Task@v8@@AEXXZX@internal@base@@SAXP8Task@v8@@AEXXZ$$QAV?$unique_ptr@VTask@v8@@U?$default_delete@VTask@v8@@@std@@@std@@@Z [0x5D2C6DC1+33]
	base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall v8::Task::*)(void),std::unique_ptr<v8::Task,std::default_delete<v8::Task> > > [0x5D2C6D1F+79]
	base::internal::Invoker<base::internal::BindState<void (__thiscall v8::Task::*)(void),std::unique_ptr<v8::Task,std::default_delete<v8::Task> > >,void __cdecl(void)>::RunImpl<void (__thiscall v8::Task::*)(void),std::tuple<std::unique_ptr<v8::Task,std::defa [0x5D2C6C8A+74]
	base::internal::Invoker<base::internal::BindState<void (__thiscall v8::Task::*)(void),std::unique_ptr<v8::Task,std::default_delete<v8::Task> > >,void __cdecl(void)>::RunOnce [0x5D2C6B04+84]
	base::OnceCallback<void __cdecl(void)>::Run [0x6F52D0A0+80]
	base::debug::TaskAnnotator::RunTask [0x6F58F213+1075]
	base::sequence_manager::internal::ThreadControllerImpl::DoWork [0x6F7A9489+1545]
	base::internal::FunctorTraits<void (__thiscall base::sequence_manager::internal::ThreadControllerImpl::*)(enum base::sequence_manager::internal::ThreadControllerImpl::WorkType),void>::Invoke<void (__thiscall base::sequence_manager::internal::ThreadControl [0x6F7ABFC1+81]
	base::internal::InvokeHelper<1,void>::MakeItSo<void (__thiscall base::sequence_manager::internal::ThreadControllerImpl::*const &)(enum base::sequence_manager::internal::ThreadControllerImpl::WorkType),base::WeakPtr<base::sequence_manager::internal::Thread [0x6F7ABE72+146]
	base::internal::Invoker<base::internal::BindState<void (__thiscall base::sequence_manager::internal::ThreadControllerImpl::*)(enum base::sequence_manager::internal::ThreadControllerImpl::WorkType),base::WeakPtr<base::sequence_manager::internal::ThreadCont [0x6F7ABDCF+111]
	base::internal::Invoker<base::internal::BindState<void (__thiscall base::sequence_manager::internal::ThreadControllerImpl::*)(enum base::sequence_manager::internal::ThreadControllerImpl::WorkType),base::WeakPtr<base::sequence_manager::internal::ThreadCont [0x6F7ABC1F+63]
	base::OnceCallback<void __cdecl(void)>::Run [0x6F52D0A0+80]
	base::debug::TaskAnnotator::RunTask [0x6F58F213+1075]
	base::MessageLoop::RunTask [0x6F6234E4+884]
	base::MessageLoop::DeferOrRunPendingTask [0x6F623CC9+73]
	base::MessageLoop::DoWork [0x6F6241A8+392]
	base::MessagePumpDefault::Run [0x6F632EF1+81]
	base::MessageLoop::Run [0x6F622DF6+486]
	base::RunLoop::Run [0x6F6FC388+488]
	content::RendererMain [0x6D0365D6+2070]
	content::RunOtherNamedProcessTypeMain [0x6D3683BF+175]
	content::ContentMainRunnerImpl::Run [0x6D3694F9+937]
	content::ContentServiceManagerMainDelegate::RunEmbedderProcess [0x6D365C72+50]
	service_manager::Main [0x5DDA3EA6+1814]
	content::ContentMain [0x6D3681DC+92]
	wWinMain [0x00CC10B1+177]
	invoke_main [0x02AC796E+30] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:123)
	__scrt_common_main_seh [0x02AC7AC1+337] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283)
	__scrt_common_main [0x02AC7B8D+13] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:326)
	wWinMainCRTStartup [0x02AC7B98+8] (f:\dd\vctools\crt\vcstartup\src\startup\exe_wwinmain.cpp:17)
	BaseThreadInitThunk [0x7559336A+18]
	RtlInitializeExceptionChain [0x77A59902+99]
	RtlInitializeExceptionChain [0x77A598D5+54]



 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f99335e0353ec6aaf7ae8a6c6b864f7a8d59e04

commit 8f99335e0353ec6aaf7ae8a6c6b864f7a8d59e04
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Mon Aug 13 02:00:35 2018

Mark budget-api/idlharness.https.any.html as crashy

TBR=peter@chromium.org
NOTRY=true

Bug:  873540 
Change-Id: I988b931a5c15ba946e2cbec30b9c1557c862ee58
Reviewed-on: https://chromium-review.googlesource.com/1171974
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582493}
[modify] https://crrev.com/8f99335e0353ec6aaf7ae8a6c6b864f7a8d59e04/third_party/WebKit/LayoutTests/TestExpectations

Labels: OS-Linux OS-Mac OS-Windows
Summary: external/wpt/budget-api/idlharness.https.any.html fails on debug builds (was: external/wpt/budget-api/idlharness.https.any.html fails on Win dbg)
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fbudget-api%2Fidlharness.https.any.html has crashes also for Linux and Mac, but they're all debug builds. It's a failing assert, so that makes sense.
Components: Blink>Bindings
script_promise_resolver.h is bindings, adding Blink>Bindings, although it's possible the problem is in in Budget API C++ code.
Components: Blink>PushAPI
Probably Budget API C++ code breaks a ScriptPromiseResolver assumption.
Cc: -peter@chromium.org
Owner: peter@chromium.org
Yeah, this is mine.
Labels: -Sheriff-Chromium
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8

commit afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8
Author: Peter Beverloo <peter@chromium.org>
Date: Mon Aug 20 13:03:45 2018

Remove the Budget API

The API hasn't been adopted by developers leading to practically zero
usage. Given that there isn't a clear path to interoperability either,
let's remove it. This has been approved per the following Intent to
Remove on blink-dev:

https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/18r3whCBv0I

The specification draft has been updated to mention its obsolescence:

https://wicg.github.io/budget-api/

There are a few bits of browser-side budget-related code that are being
used by push messaging. This CL also moves the relevant class
(BudgetDatabase) to the push messaging directory, and updated it to
maintain logic, while removing the dependency on the Mojo types.

Bug:  873540 ,  874450 
Change-Id: I98dcefe5b4333b969dd3c9bd4c09e9aaf9d65579
Reviewed-on: https://chromium-review.googlesource.com/1176083
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584418}
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/BUILD.gn
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/browser/budget_service/OWNERS
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/browser/budget_service/budget_manager.cc
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/browser/budget_service/budget_manager.h
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/browser/budget_service/budget_manager_browsertest.cc
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/browser/budget_service/budget_manager_factory.cc
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/browser/budget_service/budget_manager_factory.h
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/browser/budget_service/budget_manager_unittest.cc
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/browser/budget_service/budget_service_impl.cc
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/browser/budget_service/budget_service_impl.h
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/chrome_content_browser_manifest_overlay.json
[rename] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/push_messaging/BUILD.gn
[rename] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/push_messaging/budget.proto
[rename] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/push_messaging/budget_database.cc
[rename] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/push_messaging/budget_database.h
[rename] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/push_messaging/budget_database_unittest.cc
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/push_messaging/push_messaging_notification_manager.cc
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/push_messaging/push_messaging_notification_manager.h
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/push_messaging/push_messaging_service_factory.cc
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/test/BUILD.gn
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/test/data/budget_service/budget_test.js
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/test/data/budget_service/service_worker.js
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/test/data/budget_service/test.html
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/external/wpt/budget-api/interfaces.any-expected.txt
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/external/wpt/budget-api/interfaces.any.worker-expected.txt
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/OWNERS
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/budget-service-mock.js
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/get-budget.html
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/get-cost-fails-in-service-worker.html
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/get-cost-in-service-worker.html
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/get-cost.html
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/interfaces-in-service-worker.html
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/interfaces.html
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/reserve-in-service-worker.html
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/reserve.html
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/budget-api-origin-trial-interfaces.html
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/resources/budget-api-origin-trial-interfaces-worker-disabled.js
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/resources/budget-api-origin-trial-interfaces-worker-enabled.php
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/budget-service-on-insecure-origin.html
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/blink/public/BUILD.gn
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/public/platform/modules/budget_service/OWNERS
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/public/platform/modules/budget_service/budget_service.mojom
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/blink/renderer/modules/BUILD.gn
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/BUILD.gn
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/DEPS
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/OWNERS
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/budget_service.cc
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/budget_service.h
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/budget_service.idl
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/budget_state.cc
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/budget_state.h
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/budget_state.idl
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/navigator_budget.cc
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/navigator_budget.h
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/navigator_budget.idl
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/worker_navigator_budget.cc
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/worker_navigator_budget.h
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/worker_navigator_budget.idl
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/blink/renderer/modules/modules_idl_files.gni
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/tools/metrics/histograms/histograms.xml

Status: WontFix (was: Available)

Sign in to add a comment