tast: Rename "local data files" to "internal data files" |
||
Issue descriptionhttps://chromium.googlesource.com/chromiumos/platform/tast/+/HEAD/docs/writing_tests.md#Data-files separates test data files into two categories: * "local" (checked in to git alongside the test source) * "external" (stored in Google Cloud Storage) "local" is a confusing name since Tast also has local and remote tests (see https://chromium.googlesource.com/chromiumos/platform/tast/+/HEAD/docs/overview.md#Terminology). I think we should probably call the first category "internal data files" instead. I'm open to other naming suggestions. :-)
,
Aug 13
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast/+/082c75eeb5a323bc85976b5cb3847be28a06afdd commit 082c75eeb5a323bc85976b5cb3847be28a06afdd Author: Daniel Erat <derat@chromium.org> Date: Mon Aug 13 04:19:32 2018 tast: Rename "local" data to "internal" in writing_tests.md. Avoid potential naming confusion with local tests. Also add a note about including a date suffix in external data filenames. BUG= chromium:873507 TEST=none Change-Id: I938917d0c23dfe9b2deef226e6957121ad9ec195 Reviewed-on: https://chromium-review.googlesource.com/1172096 Reviewed-by: Shuhei Takahashi <nya@chromium.org> Tested-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/082c75eeb5a323bc85976b5cb3847be28a06afdd/docs/writing_tests.md
,
Aug 14
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/5cfaedc0c433448211c420c8566b5e15c1fd872e commit 5cfaedc0c433448211c420c8566b5e15c1fd872e Author: Daniel Erat <derat@chromium.org> Date: Tue Aug 14 00:48:58 2018 tast-tests: Update example.DataFiles for "internal" data. Update the example.DataFiles test to use the word "internal" to refer to a data file that's checked in to the repo. BUG= chromium:873507 TEST=test still passes Change-Id: Ice8dc431e76720447a0afa3462780f940fa8728d Reviewed-on: https://chromium-review.googlesource.com/1172098 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> [rename] https://crrev.com/5cfaedc0c433448211c420c8566b5e15c1fd872e/src/chromiumos/tast/local/bundles/cros/example/data/data_files_internal.txt [modify] https://crrev.com/5cfaedc0c433448211c420c8566b5e15c1fd872e/src/chromiumos/tast/local/bundles/cros/example/data_files.go
,
Aug 14
|
||
►
Sign in to add a comment |
||
Comment 1 by derat@chromium.org
, Aug 12