"TwoClientPasswordsSyncTest.SetPassphraseAndAddPassword_E2ETest" is flaky |
|||||||||
Issue description"TwoClientPasswordsSyncTest.SetPassphraseAndAddPassword_E2ETest" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySQsSBUZsYWtlIj5Ud29DbGllbnRQYXNzd29yZHNTeW5jVGVzdC5TZXRQYXNzcGhyYXNlQW5kQWRkUGFzc3dvcmRfRTJFVGVzdAw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Aug 13
Disabling the test on ChromeOS: crrev.com/c/1172265 vitaliii: could you triage this?
,
Aug 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/263604446ea2a0f7e91d9a39c91da8184a8f8c0f commit 263604446ea2a0f7e91d9a39c91da8184a8f8c0f Author: Makoto Shimazu <shimazu@chromium.org> Date: Mon Aug 13 08:28:52 2018 Disable TwoClientPasswordsSyncTest,.SetPassphraseAndAddPassword on CrOS TBR=vitaliii@chromium.org NOTRY=true Bug: 873494 Change-Id: I1395c30a000ac7033b1e8711caac1132add2ad94 Reviewed-on: https://chromium-review.googlesource.com/1172265 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582528} [modify] https://crrev.com/263604446ea2a0f7e91d9a39c91da8184a8f8c0f/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc
,
Aug 14
Removed sheriff flag since the test has been disabled.
,
Aug 14
,
Aug 16
melandory@, could you triage please?
,
Oct 15
Removing myself from owner for the bug, but it's probably good candidate for fixit
,
Nov 2
,
Nov 2
,
Nov 21
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3085800821a32e046473653f410681e1e47fa06 commit c3085800821a32e046473653f410681e1e47fa06 Author: Mikel Astiz <mastiz@chromium.org> Date: Wed Nov 21 16:21:10 2018 Block sync commits if updates pending encryption ModelTypeWorker::GetContribution() should also be blocked if some updates are pending a decryption key, otherwise a DCHECK is hit: [32730:356:1120/142053.301971:FATAL:model_type_worker.cc(471)] Check failed: entries_pending_decryption_.empty(). Since this codepath was the only remaining user of BlockForEncryption() that didn't verify entries_pending_decryption_ being empty, we change BlockForEncryption() itself to also require that condition. Bug: 873902 , 873494 Change-Id: Ic9f841380da5f81dd440d39698902a6fe2966be4 Reviewed-on: https://chromium-review.googlesource.com/c/1346392 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#610095} [modify] https://crrev.com/c3085800821a32e046473653f410681e1e47fa06/components/sync/engine_impl/model_type_worker.cc
,
Nov 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2588dbf8b48fdd817c75d9e0e38765a004af11f commit b2588dbf8b48fdd817c75d9e0e38765a004af11f Author: Mikel Astiz <mastiz@chromium.org> Date: Thu Nov 22 08:03:26 2018 Reenable test in TwoClientPasswordsSyncTest Recent patches have fixed the observed DCHECK issue, so the flakiness is believed to be gone. Bug: 873494 Change-Id: I9821f879b0be1c0ffb11004be2ae69182b6fd342 Reviewed-on: https://chromium-review.googlesource.com/c/1347357 Reviewed-by: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#610346} [modify] https://crrev.com/b2588dbf8b48fdd817c75d9e0e38765a004af11f/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc
,
Nov 22
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by chromium...@appspot.gserviceaccount.com
, Aug 13