New issue
Advanced search Search tips

Issue 873486 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----

Blocked on:
issue 872949


Participants' hotlists:
Launcher-Tech-Debt


Sign in to add a comment

Remove dead code from disabling webstore search

Project Member Reported by newcomer@chromium.org, Aug 12

Issue description

All in the title
 
Blockedon: 872949
Status: Assigned (was: Untriaged)
Labels: -Pri-2 Pri-1
Labels: -M-71 M-72
Labels: Tablet-Polish
Labels: -Pri-1 Pri-2
Labels: -Pri-2 -Tablet-Polish Pri-1
Owner: kaznacheev@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81528881b641b6b6e947121fdf79b7174bbb1332

commit 81528881b641b6b6e947121fdf79b7174bbb1332
Author: Vladislav Kaznacheev <kaznacheev@google.com>
Date: Mon Oct 22 21:57:25 2018

Remove dead code for WebStore search

Bug:  873486 
Test: Chrome builds and runs
Change-Id: I507b97aa1bb0c894599037c5a8cc85286ebc9bd9
Reviewed-on: https://chromium-review.googlesource.com/c/1292249
Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601740}
[modify] https://crrev.com/81528881b641b6b6e947121fdf79b7174bbb1332/chrome/app/chromium_strings.grd
[modify] https://crrev.com/81528881b641b6b6e947121fdf79b7174bbb1332/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/81528881b641b6b6e947121fdf79b7174bbb1332/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/9b5c9d9b4b515a642fbed7804579217e0569dff3/chrome/browser/ui/app_list/search/common/webservice_cache.cc
[delete] https://crrev.com/9b5c9d9b4b515a642fbed7804579217e0569dff3/chrome/browser/ui/app_list/search/common/webservice_cache.h
[delete] https://crrev.com/9b5c9d9b4b515a642fbed7804579217e0569dff3/chrome/browser/ui/app_list/search/common/webservice_cache_factory.cc
[delete] https://crrev.com/9b5c9d9b4b515a642fbed7804579217e0569dff3/chrome/browser/ui/app_list/search/common/webservice_cache_factory.h
[delete] https://crrev.com/9b5c9d9b4b515a642fbed7804579217e0569dff3/chrome/browser/ui/app_list/search/common/webservice_search_provider.cc
[delete] https://crrev.com/9b5c9d9b4b515a642fbed7804579217e0569dff3/chrome/browser/ui/app_list/search/common/webservice_search_provider.h
[modify] https://crrev.com/81528881b641b6b6e947121fdf79b7174bbb1332/chrome/browser/ui/app_list/search/search_controller_factory.cc
[modify] https://crrev.com/81528881b641b6b6e947121fdf79b7174bbb1332/chrome/browser/ui/app_list/search/search_util.h
[delete] https://crrev.com/9b5c9d9b4b515a642fbed7804579217e0569dff3/chrome/browser/ui/app_list/search/search_webstore_result.cc
[delete] https://crrev.com/9b5c9d9b4b515a642fbed7804579217e0569dff3/chrome/browser/ui/app_list/search/search_webstore_result.h
[delete] https://crrev.com/9b5c9d9b4b515a642fbed7804579217e0569dff3/chrome/browser/ui/app_list/search/webstore/webstore_installer.cc
[delete] https://crrev.com/9b5c9d9b4b515a642fbed7804579217e0569dff3/chrome/browser/ui/app_list/search/webstore/webstore_installer.h
[delete] https://crrev.com/9b5c9d9b4b515a642fbed7804579217e0569dff3/chrome/browser/ui/app_list/search/webstore/webstore_provider.cc
[delete] https://crrev.com/9b5c9d9b4b515a642fbed7804579217e0569dff3/chrome/browser/ui/app_list/search/webstore/webstore_provider.h
[delete] https://crrev.com/9b5c9d9b4b515a642fbed7804579217e0569dff3/chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc
[delete] https://crrev.com/9b5c9d9b4b515a642fbed7804579217e0569dff3/chrome/browser/ui/app_list/search/webstore/webstore_result.cc
[delete] https://crrev.com/9b5c9d9b4b515a642fbed7804579217e0569dff3/chrome/browser/ui/app_list/search/webstore/webstore_result.h
[modify] https://crrev.com/81528881b641b6b6e947121fdf79b7174bbb1332/chrome/test/BUILD.gn
[modify] https://crrev.com/81528881b641b6b6e947121fdf79b7174bbb1332/components/arc/arc_util.cc
[modify] https://crrev.com/81528881b641b6b6e947121fdf79b7174bbb1332/components/arc/arc_util.h

Status: Fixed (was: Started)

Sign in to add a comment