A crash occur when open a folder with page break item |
||
Issue descriptionWith #enable-apps-grid-gap enabled. I see a folder with an invisible item inside, then opening the folder will cause a crash. By doing log, I found that the invisible item is a page break item that should never exist in folder. And if the crash happens, it will always happen because the page break item always exists. So we need to way to remove it.
,
Aug 13
I looked into the code, the place we add page break item is PagedViewStructure::SaveToMetadata() [1] which should only be called outside folder. One possible explanation is that the page break item is added during development and stayed in server, so it only happens for my account.
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/defada06fc810fe128a72552fb9badaa0934cbae commit defada06fc810fe128a72552fb9badaa0934cbae Author: Weidong Guo <weidongg@chromium.org> Date: Wed Aug 15 01:58:32 2018 Fix a crash when apps grid gap is enabled Background: A crash occur when a page break item exists in folder. (Not sure why a page break item gets into folder.) Changes: Remove the page break item from folder if it exists. Bug: 873485 Change-Id: I0cc435ae8d47c056eeec4b04a8afe7f5cc989588 Reviewed-on: https://chromium-review.googlesource.com/1172071 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#583125} [modify] https://crrev.com/defada06fc810fe128a72552fb9badaa0934cbae/chrome/browser/ui/app_list/app_list_syncable_service.cc [modify] https://crrev.com/defada06fc810fe128a72552fb9badaa0934cbae/chrome/browser/ui/app_list/app_list_syncable_service.h
,
Aug 15
|
||
►
Sign in to add a comment |
||
Comment 1 by xiy...@chromium.org
, Aug 13