New issue
Advanced search Search tips

Issue 873432 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in av_encryption_info_add_side_data

Project Member Reported by ClusterFuzz, Aug 11

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4906706245779456

Fuzzer: inferno_flicker
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000018
Crash State:
  av_encryption_info_add_side_data
  mov_read_packet
  ff_read_packet
  
Sanitizer: thread (TSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_tsan_chrome_mp&range=582254:582257

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4906706245779456

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 11

Components: Internals>Media>FFmpeg
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Aug 11

Cc: modma...@google.com
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

libavutil/encryption_info: Add unit tests. by modmaker@google.com - https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/69bd73b3ff873abb43de9db062b04425de153643

libavutil/encryption_info: Allow multiple init info. by modmaker@google.com - https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/b86c5757a2bf2a589b3982d6b85401165deb4958

avformat/mov: Expose encryption info to the app. by modmaker@google.com - https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/7e22f5d457fa042292741c1f5c38232ba10dbea2

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Cc: tguilbert@chromium.org
Cc: -modma...@google.com kkaluri@chromium.org
Labels: M-70
Owner: modma...@google.com
Status: Assigned (was: Untriaged)
Predator has provided 3 possible suspect CL's

Since suspected CL's have same author, hence assigning it to modmaker@ for further triage.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/ddbe19a87228d61d131fe3b1876cd68bb4cbc3be

commit ddbe19a87228d61d131fe3b1876cd68bb4cbc3be
Author: Jacob Trimble <modmaker@google.com>
Date: Tue Aug 14 21:21:22 2018

avformat/mov: Allow saio/saiz in clear content.

If there is a saio/saiz in clear content, we shouldn't create the
encryption index if we don't already have one.  Otherwise it will
confuse the cenc_filter.

Bug:  873432 
Change-Id: I1bfb20f590d667a2ff3c4fcb5efecbcc7ed99387
Reviewed-on: https://chromium-review.googlesource.com/1174892
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>

[modify] https://crrev.com/ddbe19a87228d61d131fe3b1876cd68bb4cbc3be/libavformat/mov.c
[modify] https://crrev.com/ddbe19a87228d61d131fe3b1876cd68bb4cbc3be/chromium/patches/README

Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/316c4b89a0eca5af9c3ba3766c029f62eed5c325

commit 316c4b89a0eca5af9c3ba3766c029f62eed5c325
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Wed Aug 15 00:48:11 2018

Roll src/third_party/ffmpeg/ 5659adb8f..ddbe19a87 (2 commits)

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/5659adb8fc6f..ddbe19a87228

$ git log 5659adb8f..ddbe19a87 --date=short --no-merges --format='%ad %ae %s'
2018-08-14 modmaker avformat/mov: Allow saio/saiz in clear content.
2018-08-13 modmaker avutil/encryption_info: Fix size calculation.

Created with:
  roll-dep src/third_party/ffmpeg

Bug:  873432 ,  873693 
Change-Id: I2d15352a47c30de4bf75df064388a8d3803930c2
Tbr: tguilbert
Reviewed-on: https://chromium-review.googlesource.com/1175147
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583108}
[modify] https://crrev.com/316c4b89a0eca5af9c3ba3766c029f62eed5c325/DEPS

Project Member

Comment 9 by ClusterFuzz, Aug 15

ClusterFuzz has detected this issue as fixed in range 583107:583108.

Detailed report: https://clusterfuzz.com/testcase?key=4906706245779456

Fuzzer: inferno_flicker
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000018
Crash State:
  av_encryption_info_add_side_data
  mov_read_packet
  ff_read_packet
  
Sanitizer: thread (TSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_tsan_chrome_mp&range=582254:582257
Fixed: https://clusterfuzz.com/revisions?job=linux_tsan_chrome_mp&range=583107:583108

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4906706245779456

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Aug 15

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4906706245779456 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment