BubbleDialogDelegateView should live in bubble_dialog_delegate_view.* instead of bubble_dialog_delegate.*
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6657440b025d75ff5fd5c810273b0986c263a07c commit 6657440b025d75ff5fd5c810273b0986c263a07c Author: Robert Liao <robliao@chromium.org> Date: Mon Aug 13 18:46:00 2018 Rename bubble_dialog_delegate.* to bubble_dialog_delegate_view.* This is part 1 of 3 for aligning BubbleDialogDelegateView with its filename. BUG= 873422 Change-Id: Ie57ac06eeda6afde915d3de6a1b60770a22e0da7 Reviewed-on: https://chromium-review.googlesource.com/1171907 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#582651} [modify] https://crrev.com/6657440b025d75ff5fd5c810273b0986c263a07c/ui/views/BUILD.gn [modify] https://crrev.com/6657440b025d75ff5fd5c810273b0986c263a07c/ui/views/bubble/bubble_dialog_delegate.h [rename] https://crrev.com/6657440b025d75ff5fd5c810273b0986c263a07c/ui/views/bubble/bubble_dialog_delegate_view.cc [add] https://crrev.com/6657440b025d75ff5fd5c810273b0986c263a07c/ui/views/bubble/bubble_dialog_delegate_view.h [rename] https://crrev.com/6657440b025d75ff5fd5c810273b0986c263a07c/ui/views/bubble/bubble_dialog_delegate_view_unittest.cc [modify] https://crrev.com/6657440b025d75ff5fd5c810273b0986c263a07c/ui/views/bubble/bubble_frame_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3cea15a165713b16e478f14d238786276d04f0f7 commit 3cea15a165713b16e478f14d238786276d04f0f7 Author: Robert Liao <robliao@chromium.org> Date: Mon Aug 13 21:10:19 2018 Update bubble_dialog_delegate.h Includes to bubble_dialog_delegate_view.h This is part 2 of 3 for aligning BubbleDialogDelegateView with its filename. BUG= 873422 TBR=sky@chromium.org Change-Id: I98721ecb7ad384aa74f9a8129e6f73433b06b856 Reviewed-on: https://chromium-review.googlesource.com/1171918 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#582704} [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ash/assistant/ui/assistant_container_view.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ash/assistant/ui/assistant_container_view.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ash/login/ui/login_base_bubble_view.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ash/public/cpp/immersive/immersive_fullscreen_controller.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ash/shelf/overflow_bubble_view.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ash/shelf/shelf_tooltip_bubble_base.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ash/shelf/shelf_tooltip_manager_unittest.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ash/shell/bubble.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ash/system/network/network_state_list_detailed_view.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ash/system/palette/palette_welcome_bubble.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ash/wm/immersive_focus_watcher_classic.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ash/wm/immersive_fullscreen_controller_unittest.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/chromeos/lock_screen_apps/toast_dialog_view.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/accessibility/invert_bubble_view.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/autofill/card_unmask_prompt_views.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/close_bubble_on_tab_activation_helper.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/content_setting_bubble_contents.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/critical_notification_bubble_view.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest_views.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/extensions/extension_popup.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/feature_promos/feature_promo_bubble_view.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/global_error_bubble_view.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/ime/ime_warning_bubble_view.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/media_router/cast_dialog_view.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/media_router/cloud_services_dialog_view.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/media_router/media_remoting_dialog_view.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/network_profile_bubble_view.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/outdated_upgrade_bubble_view.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/page_action/page_action_icon_view.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/page_info/page_info_bubble_view_base.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/passwords/account_chooser_dialog_view.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/permission_bubble/chooser_bubble_ui.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/permission_bubble/chooser_bubble_ui_views.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/profiles/profile_chooser_view.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/relaunch_notification/relaunch_recommended_bubble_view.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/session_crashed_bubble_view.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/toolbar/browser_actions_container.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/toolbar/home_button.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ui/chromeos/ime/candidate_window_view.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ui/chromeos/ime/infolist_window.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ui/chromeos/ime/mode_indicator_view.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ui/views/bubble/bubble_frame_view.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ui/views/bubble/bubble_frame_view_unittest.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ui/views/bubble/info_bubble.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ui/views/bubble/tray_bubble_view.h [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ui/views/examples/bubble_example.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ui/views/examples/dialog_example.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ui/views/focus/focus_manager_unittest.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ui/views/focus/focus_search.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ui/views/touchui/touch_selection_menu_runner_views.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ui/views/view_properties.cc [modify] https://crrev.com/3cea15a165713b16e478f14d238786276d04f0f7/ui/views/widget/widget_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4c8983688edd2725a5bfb4a9538047f7a2efa27 commit d4c8983688edd2725a5bfb4a9538047f7a2efa27 Author: Robert Liao <robliao@chromium.org> Date: Mon Aug 13 23:21:29 2018 Update bubble_dialog_delegate.h mm File Includes to bubble_dialog_delegate_view.h This is part 2 of 3 for aligning BubbleDialogDelegateView with its filename. BUG= 873422 TBR=ellyjones@chromium.org Change-Id: Ie012caded8d230c81a5e4a0ced86195d679b45f6 Reviewed-on: https://chromium-review.googlesource.com/1173409 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#582740} [modify] https://crrev.com/d4c8983688edd2725a5bfb4a9538047f7a2efa27/chrome/browser/ui/cocoa/bubble_anchor_helper_views.mm [modify] https://crrev.com/d4c8983688edd2725a5bfb4a9538047f7a2efa27/chrome/browser/ui/cocoa/bubble_anchor_helper_views_unittest.mm [modify] https://crrev.com/d4c8983688edd2725a5bfb4a9538047f7a2efa27/chrome/browser/ui/cocoa/extensions/extension_popup_views_mac.mm [modify] https://crrev.com/d4c8983688edd2725a5bfb4a9538047f7a2efa27/chrome/browser/ui/cocoa/page_info/page_info_bubble_views_mac_browsertest.mm [modify] https://crrev.com/d4c8983688edd2725a5bfb4a9538047f7a2efa27/chrome/browser/ui/cocoa/permission_bubble/chooser_bubble_ui_views_mac.mm [modify] https://crrev.com/d4c8983688edd2725a5bfb4a9538047f7a2efa27/ui/views/widget/native_widget_mac_interactive_uitest.mm [modify] https://crrev.com/d4c8983688edd2725a5bfb4a9538047f7a2efa27/ui/views/widget/native_widget_mac_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/226492880c39209ab70a6a24f48ae6ce4dc6d43c commit 226492880c39209ab70a6a24f48ae6ce4dc6d43c Author: Robert Liao <robliao@chromium.org> Date: Tue Aug 14 17:42:33 2018 Remove bubble_dialog_delegate.h Developers should include bubble_dialog_delegate_view.h instead. This is part 3 of 3 for aligning BubbleDialogDelegateView with its filename. BUG= 873422 Change-Id: Ifd33203baf4d057c476026394d2833d0701e25e3 Reviewed-on: https://chromium-review.googlesource.com/1171919 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#582965} [modify] https://crrev.com/226492880c39209ab70a6a24f48ae6ce4dc6d43c/ui/views/BUILD.gn [delete] https://crrev.com/e92723a613ec4bbb7ca6c7d89567787250bc02bb/ui/views/bubble/bubble_dialog_delegate.h
Comment 1 by bugdroid1@chromium.org
, Aug 13