New issue
Advanced search Search tips

Issue 873394 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Implement motion spec for homecher to overview transition

Project Member Reported by mccanny@chromium.org, Aug 10

Issue description

When pressing the overview button from homecher, or the homecher button from overview, the current transition is janky.

New motion spec available here:
http://go/wm-motion#project-homecher-transition


 
Cc: weidongg@chromium.org
Labels: -Pri-3 OS-Chrome Pri-1
Status: Assigned (was: Untriaged)
+weidongg fyi
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1182083823b0b6c3445a5caf884572ca1c21147

commit f1182083823b0b6c3445a5caf884572ca1c21147
Author: Sammie Quon <sammiequon@google.com>
Date: Mon Aug 20 18:20:09 2018

overview: Add transition to home launcher.

The spec is here:
https://mccanny.users.x20web.corp.google.com/www/wm-motion/index.html#project-homecher-transition.

This cl adds the overview slide in/out part of the spec. The launcher window
animations will be added in a later cl.

On entering overview, check if home launcher is enabled and if all windows are
minimized, then slide overview in, otherwise use normal transition. On exit
overview, check if home launcher is enabled and if all windows are minimized,
then slide overview out, otherwise use normal transition. If home launcher
button is explicitly pressed while in overview, minimized all windows without
animation and create mirror windows for them in overview, then slide those out.
We could also slide the original windows on exit, but then we would have to
worry about minimizing after animation and other stuff, so I think this way
is simpler.

Test: manual
Bug:  873394 
Change-Id: I1deaa58334ce41c28907af60c137ebc2d147c3c9
Reviewed-on: https://chromium-review.googlesource.com/1176346
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584503}
[modify] https://crrev.com/f1182083823b0b6c3445a5caf884572ca1c21147/ash/shelf/app_list_shelf_item_delegate.cc
[modify] https://crrev.com/f1182083823b0b6c3445a5caf884572ca1c21147/ash/wm/overview/overview_animation_type.h
[modify] https://crrev.com/f1182083823b0b6c3445a5caf884572ca1c21147/ash/wm/overview/overview_utils.cc
[modify] https://crrev.com/f1182083823b0b6c3445a5caf884572ca1c21147/ash/wm/overview/overview_utils.h
[modify] https://crrev.com/f1182083823b0b6c3445a5caf884572ca1c21147/ash/wm/overview/scoped_overview_animation_settings.cc
[modify] https://crrev.com/f1182083823b0b6c3445a5caf884572ca1c21147/ash/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/f1182083823b0b6c3445a5caf884572ca1c21147/ash/wm/overview/scoped_transform_overview_window.h
[modify] https://crrev.com/f1182083823b0b6c3445a5caf884572ca1c21147/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/f1182083823b0b6c3445a5caf884572ca1c21147/ash/wm/overview/window_grid.h
[modify] https://crrev.com/f1182083823b0b6c3445a5caf884572ca1c21147/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/f1182083823b0b6c3445a5caf884572ca1c21147/ash/wm/overview/window_selector.h
[modify] https://crrev.com/f1182083823b0b6c3445a5caf884572ca1c21147/ash/wm/overview/window_selector_controller.cc
[modify] https://crrev.com/f1182083823b0b6c3445a5caf884572ca1c21147/ash/wm/overview/window_selector_controller.h
[modify] https://crrev.com/f1182083823b0b6c3445a5caf884572ca1c21147/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/f1182083823b0b6c3445a5caf884572ca1c21147/ash/wm/overview/window_selector_item.h
[modify] https://crrev.com/f1182083823b0b6c3445a5caf884572ca1c21147/ash/wm/overview/window_selector_unittest.cc

This is working for non arc windows, I'll have  investigate a bit why arc windows are working.
 Issue 869621  has been merged into this issue.
Labels: Not-Touch-Friendly-Launcher
Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/317deb56c8ee2d08cec03c397f726d2bf188fd73

commit 317deb56c8ee2d08cec03c397f726d2bf188fd73
Author: Sammie Quon <sammiequon@google.com>
Date: Thu Sep 06 16:36:28 2018

overview: Introduce OnOverviewModeEndingAnimationCompelete shell observer.

The first usage will be full screen applist, so it doesnt show up while
overview windows are moving around.

Also move blur to after animations, and fix a bug with app list overview
animation pause, and add a pause for homecher -> overview window
animations.

Test: manual
Bug:  873394 , 871875, 880613
Change-Id: Id9ede4b412c609cff6a1ec4c841b20aaab9aa5e2
Reviewed-on: https://chromium-review.googlesource.com/1199814
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589186}
[modify] https://crrev.com/317deb56c8ee2d08cec03c397f726d2bf188fd73/ash/app_list/app_list_controller_impl.cc
[modify] https://crrev.com/317deb56c8ee2d08cec03c397f726d2bf188fd73/ash/app_list/app_list_controller_impl.h
[modify] https://crrev.com/317deb56c8ee2d08cec03c397f726d2bf188fd73/ash/app_list/presenter/app_list_presenter_impl.cc
[modify] https://crrev.com/317deb56c8ee2d08cec03c397f726d2bf188fd73/ash/shell.cc
[modify] https://crrev.com/317deb56c8ee2d08cec03c397f726d2bf188fd73/ash/shell.h
[modify] https://crrev.com/317deb56c8ee2d08cec03c397f726d2bf188fd73/ash/shell_observer.h
[modify] https://crrev.com/317deb56c8ee2d08cec03c397f726d2bf188fd73/ash/wm/overview/overview_utils.cc
[modify] https://crrev.com/317deb56c8ee2d08cec03c397f726d2bf188fd73/ash/wm/overview/scoped_overview_animation_settings.cc
[modify] https://crrev.com/317deb56c8ee2d08cec03c397f726d2bf188fd73/ash/wm/overview/window_selector_controller.cc

Labels: Merge-Request-70
Project Member

Comment 10 by sheriffbot@chromium.org, Sep 8

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 11

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fab2cce4c4d7c334488bb6d0f56feb64d203446e

commit fab2cce4c4d7c334488bb6d0f56feb64d203446e
Author: Alex Newcomer <newcomer@chromium.org>
Date: Tue Sep 11 21:33:13 2018

overview: Introduce OnOverviewModeEndingAnimationCompelete shell observer.

The first usage will be full screen applist, so it doesnt show up while
overview windows are moving around.

Also move blur to after animations, and fix a bug with app list overview
animation pause, and add a pause for homecher -> overview window
animations.

TBR=sammiequon@google.com

(cherry picked from commit 317deb56c8ee2d08cec03c397f726d2bf188fd73)

Test: manual
Bug:  873394 , 871875, 880613
Change-Id: Id9ede4b412c609cff6a1ec4c841b20aaab9aa5e2
Reviewed-on: https://chromium-review.googlesource.com/1199814
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589186}
Reviewed-on: https://chromium-review.googlesource.com/1220686
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#296}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/fab2cce4c4d7c334488bb6d0f56feb64d203446e/ash/app_list/app_list_controller_impl.cc
[modify] https://crrev.com/fab2cce4c4d7c334488bb6d0f56feb64d203446e/ash/app_list/app_list_controller_impl.h
[modify] https://crrev.com/fab2cce4c4d7c334488bb6d0f56feb64d203446e/ash/app_list/presenter/app_list_presenter_impl.cc
[modify] https://crrev.com/fab2cce4c4d7c334488bb6d0f56feb64d203446e/ash/shell.cc
[modify] https://crrev.com/fab2cce4c4d7c334488bb6d0f56feb64d203446e/ash/shell.h
[modify] https://crrev.com/fab2cce4c4d7c334488bb6d0f56feb64d203446e/ash/shell_observer.h
[modify] https://crrev.com/fab2cce4c4d7c334488bb6d0f56feb64d203446e/ash/wm/overview/overview_utils.cc
[modify] https://crrev.com/fab2cce4c4d7c334488bb6d0f56feb64d203446e/ash/wm/overview/scoped_overview_animation_settings.cc
[modify] https://crrev.com/fab2cce4c4d7c334488bb6d0f56feb64d203446e/ash/wm/overview/window_selector_controller.cc

Sign in to add a comment